595779 - Updating mozilla-build to sed v4.0.7 causes |sed.exe: -e expression #1, char 18: Unterminated `s' command|

Status: RESOLVED WORKSFORME

(Firefox Build System :: MozillaBuild, task)

Description

[Philip Chee]

Attachment: make stdout

When working on https://bugzilla.mozilla.org/show_bug.cgi?id=595630#c2
I had to update the sed in mozilla-build (3.0.2) to 4.0.7 so that the following script copied from Bug 590039 would not fall over:

$ find -name '*.css' -type f -exec sed -i -e 's/\<MozBoxShadow\>/boxShadow/g;s/-moz-box-shadow/box-shadow/gi' {} \;

v3.0.2 did not understand the -i or --in-place switch. However using sed 4.0.7 caused make -f client.mk to fail with:

C:\DEV\mozilla-build\msys\bin\sed.exe: -e expression #1, char 18: Unterminated `s' command
C:\DEV\mozilla-build\msys\bin\sed.exe: -e expression #1, char 18: Unterminated `s' command

Either client.mk should be fixed or scripts used to generate patches should not use sed with the '-i' option.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The goal of MozillaBuild is not to provide a complete Unix emulation.  I think this is WONTFIX, but I'll leave that to ted.

Comment 2

[Philip Chee]

Hmm why aren't *nix platforms (that presumably have newer versions of sed) crapping out on make -f client.mk?

Comment 3

[(not currently active) Ted Mielczarek]

This isn't client.mk, it's something in configure. You might be able to look at config.log to see if you can pinpoint where that sed error is happening. It's probably a Windows-only check (like the MSVC version check), which is why it doesn't break other platforms.

Comment 4

[Philip Chee]

>  It's
> probably a Windows-only check (like the MSVC version check)

config.log is singularly uninformative but looking at the stdout again I see that it is failing at:
configure: error: Invalid value for --with-windows-version (), must be 502, 600 or 601

and the sed error occurs immediately after:
--with-windows-version=601

So I suspect that sed 4.0.7 isn't parsing this line correctly.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

sed was updated to version 4.2.1 over in bug 373784 from the link below:
http://downloads.sourceforge.net/project/mingw/MSYS/Base/sed/sed-4.2.1-1/sed-4.2.1-1-msys-1.0.11-bin.tar.lzma

If you feel like trying it out, I'd love to know if it works OK for you.

Comment 6

[Philip Chee]

I must have updated to a newer sed in the intervening period (I had a disk crash and reinstalled all my dev tools from scratch). Resolving as WORKSFORME