Closed
Bug 596129
Opened 14 years ago
Closed 14 years ago
Clean up "BuildID", "yes", and "no" strings in Localizable.strings
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alqahira, Assigned: alqahira)
Details
Attachments
(1 file)
|
3.23 KB,
patch
|
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
While looking up the AlreadyRunningMsg for philippe for bug 596118, I discovered three nearby strings that needed cleaning. "BuildID" belonged to the old, custom CHAboutBox; there are no references to the string as long ago as MOZILLA_1_7_BRANCH, so it's cleared for removal. The unfortunately-named "yes" and "no" are only used by PrivacyPane.mm (for the "secure" column in the cookies table). They should move to Privacy's own Localizable.strings, and gain sane names (try saying that five times fast!). I waffled between "CookieSecureFooLabel" and "CookieSecurityFooLabel"; if you have a preference (or a better suggestion), I'll Make-It-So™.
Attachment #474974 -
Flags: superreview?(stuart.morgan+bugzilla)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 474974 [details] [diff] [review] Paging housekeeping! sr=smorgan
Attachment #474974 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/camino/rev/7cde70916f18
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•