596338 - Undefined symbol js::JMCheckLogging

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Karsten Düsterloh]

Well, I know PPC isn't supported officially anymore, but maybe OpenSolaris is again affected...

Building today's SeaMonkey (debug) trunk dies with

Undefined symbols:
  "js::JMCheckLogging()", referenced from:
      js::RunScript(JSContext*, JSScript*, JSFunction*, JSObject*)   in jsinvoke.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[5]: *** [libmozjs.dylib] Error 1
make[4]: *** [libs_tier_js] Error 2
make[3]: *** [tier_js] Error 2
make[2]: *** [default] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 1

[Ginn Chen]

I don't have this problem on Solaris.

Comment 2

[Ginn Chen]

I can recreate the problem with SPARC debug build.

Comment 3

[Ginn Chen]

Attachment: patch

Comment 4

[Karsten Düsterloh]

Yep, my Mac is happy again with this patch! :-D

Comment 5

[Karsten Düsterloh]

Can we get this checked in, please? :) 
(I could do, if necessary.)

Comment 7

[Ginn Chen]

http://hg.mozilla.org/tracemonkey/rev/cec3c87c99b1

Comment 8

[Phil Ringnalda (:philor)]

This broke --disable-methodjit builds (not yet visible on tbpl.m.o, but visible on http://dev.philringnalda.com/tbpl/?tree=TraceMonkey and tinderbox.m.o) - is that maybe missing something like a "|| defined JS_TRACER" at the end?

Comment 9

[Phil Ringnalda (:philor)]

Which, with some parens, http://hg.mozilla.org/tracemonkey/rev/e3c6960a4868 did.

Comment 10

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/cec3c87c99b1

Comment 11

[Ginn Chen]

http://hg.mozilla.org/tracemonkey/rev/e3c6960a4868 fixed building with --no-methodjit on x86, but this bug appears again.

Comment 12

[Ginn Chen]

Attachment: patch v2

try again, tested on SPARC and x86 with no methodjit

Comment 13

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: another idea

Sorry I broke your patch.

I looked this over carefully. As far as I can tell, the problem is that we need Logging code both for the methodjit and for YARR. On Sparc and PPC, we don't have either. On x86, --disable-methodjit seems to leave YARR turned on.

Could you try this patch instead? I think it's a little cleaner. It works in both modes for me on x86. I don't have access to Sparc or PPC though.

Comment 14

[Paul Biggar]

(In reply to comment #13)
> I looked this over carefully. As far as I can tell, the problem is that we need
> Logging code both for the methodjit and for YARR. On Sparc and PPC, we don't
> have either. On x86, --disable-methodjit seems to leave YARR turned on.

I know it's not everybodies favourite solution, but bug 633702 is one solution (combining the methodjit and yarr flags).

Comment 15

[Ginn Chen]

(In reply to comment #13)
> Created attachment 512879 [details] [diff] [review]
> another idea
> 

Works for me on SPARC, thanks!

Comment 16

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

http://hg.mozilla.org/tracemonkey/rev/cf342441a8d5

Comment 17

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/cf342441a8d5