Status

()

Core
DOM
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

({dev-doc-complete})

Trunk
x86
Mac OS X
dev-doc-complete
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(3 attachments)

There has been a few File-API related spec changes to features that we've added since FF3.6. In particular:

myFormData = formelement.getFormData();
is now
myFormData = new FormData(formelement);

and

img.src = file.url
is now
img.src = window.createBlobURL(file);
and comes with a matching
window.revokeBlobURL(someurl);


Patches coming up
Created attachment 475245 [details] [diff] [review]
Fix FormData
Assignee: nobody → jonas
Attachment #475245 - Flags: review?(jst)
Created attachment 475246 [details] [diff] [review]
Fix File.url -> createBlobURL
Attachment #475246 - Flags: review?(jst)
Since this is new syntax, I suspect we should treat it as a beta7 blocker.
blocking2.0: --- → beta7+

Updated

7 years ago
Attachment #475245 - Flags: review?(jst) → review+

Updated

7 years ago
Attachment #475246 - Flags: review?(jst) → review+
Checked in

http://hg.mozilla.org/mozilla-central/rev/1cfb952b69be
http://hg.mozilla.org/mozilla-central/rev/7fff69efb85e

Thanks for the quick review
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Duplicate of this bug: 593762
Keywords: dev-doc-needed
Crap! I missed to remove the existing File.url property. Patch coming up to do that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 476401 [details] [diff] [review]
Remove File.url
Attachment #476401 - Flags: review?(jst)

Updated

7 years ago
Attachment #476401 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/905b39a5523c

Checked in last patch
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Comment 9

7 years ago
So does this all work properly when we're reusing inner window for different documents?
Can you describe the situation you are concerned about?
The text for this has been updated here:

https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest#Using_FormData_objects

And the url property has been removed from the File object reference:

https://developer.mozilla.org/en/DOM/File

That should cover this.
Keywords: dev-doc-needed → dev-doc-complete

Updated

7 years ago
Depends on: 599966
You need to log in before you can comment on or make changes to this bug.