596385 - Update File APIs to spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

There has been a few File-API related spec changes to features that we've added since FF3.6. In particular:

myFormData = formelement.getFormData();
is now
myFormData = new FormData(formelement);

and

img.src = file.url
is now
img.src = window.createBlobURL(file);
and comes with a matching
window.revokeBlobURL(someurl);


Patches coming up

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Fix FormData

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Fix File.url -> createBlobURL

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Since this is new syntax, I suspect we should treat it as a beta7 blocker.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in

http://hg.mozilla.org/mozilla-central/rev/1cfb952b69be
http://hg.mozilla.org/mozilla-central/rev/7fff69efb85e

Thanks for the quick review

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Crap! I missed to remove the existing File.url property. Patch coming up to do that.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Remove File.url

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

http://hg.mozilla.org/mozilla-central/rev/905b39a5523c

Checked in last patch

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

So does this all work properly when we're reusing inner window for different documents?

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Can you describe the situation you are concerned about?

Comment 11

[Eric Shepherd [:sheppy]]

The text for this has been updated here:

https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest#Using_FormData_objects

And the url property has been removed from the File object reference:

https://developer.mozilla.org/en/DOM/File

That should cover this.