Closed Bug 596385 Opened 14 years ago Closed 14 years ago

Update File APIs to spec

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: sicking, Assigned: sicking)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

There has been a few File-API related spec changes to features that we've added since FF3.6. In particular:

myFormData = formelement.getFormData();
is now
myFormData = new FormData(formelement);

and

img.src = file.url
is now
img.src = window.createBlobURL(file);
and comes with a matching
window.revokeBlobURL(someurl);


Patches coming up
Attached patch Fix FormDataSplinter Review
Assignee: nobody → jonas
Attachment #475245 - Flags: review?(jst)
Since this is new syntax, I suspect we should treat it as a beta7 blocker.
blocking2.0: --- → beta7+
Attachment #475245 - Flags: review?(jst) → review+
Attachment #475246 - Flags: review?(jst) → review+
Checked in

http://hg.mozilla.org/mozilla-central/rev/1cfb952b69be
http://hg.mozilla.org/mozilla-central/rev/7fff69efb85e

Thanks for the quick review
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Crap! I missed to remove the existing File.url property. Patch coming up to do that.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #476401 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/905b39a5523c

Checked in last patch
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
So does this all work properly when we're reusing inner window for different documents?
Can you describe the situation you are concerned about?
The text for this has been updated here:

https://developer.mozilla.org/En/XMLHttpRequest/Using_XMLHttpRequest#Using_FormData_objects

And the url property has been removed from the File object reference:

https://developer.mozilla.org/en/DOM/File

That should cover this.
Depends on: 599966
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.