596498 - E10: remote AlertsService

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Doug Turner (:dougt)]

Attachment: patch v.1

We should forward alerts service.

Comment 1

[Josh Matthews [:jdm]]

Comment on attachment 475439 [details] [diff] [review]
patch v.1

>+    // auto remove when alertfinished is recv

s/recv/received

>+ContentChild::AddRemoteAlertObserver(const nsString& aData,
>+                                    nsIObserver* aObserver)

align.

Looks good. r=me

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 475439 [details] [diff] [review]
patch v.1

Tested via desktop notifications in Fennec

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/904b6d091d4e

Comment 4

[[e-mail]]

Comment on attachment 475439 [details] [diff] [review]
patch v.1

> NS_IMETHODIMP nsAlertsService::ShowAlertNotification(const nsAString & aImageUrl, const nsAString & aAlertTitle, 
>                                                      const nsAString & aAlertText, PRBool aAlertTextClickable,
>                                                      const nsAString & aAlertCookie,
>                                                      nsIObserver * aAlertListener,
>                                                      const nsAString & aAlertName)
> {
>+#ifdef MOZ_IPC
>+  if (XRE_GetProcessType() == GeckoProcessType_Content) {
>+    ContentChild* cpc = ContentChild::GetSingleton();
>+
>+    if (aAlertListener)
>+      cpc->AddRemoteAlertObserver(nsDependentString(aAlertCookie), aAlertListener);
>+
>+    cpc->SendShowAlertNotification(nsAutoString(aImageUrl),
>+                                   nsAutoString(aAlertTitle),
>+                                   nsAutoString(aAlertText),
>+                                   aAlertTextClickable,
>+                                   nsAutoString(aAlertCookie),
>+                                   nsAutoString(aAlertName));
nsAString isn't guaranteed to be null-terminated. So you can't safely wrap it in an nsDependentString. (I don't know why nsDependentString has an nsAString constructor.) nsAutoString does work, although it's a waste of stack space as nsString would suffice.