The default bug view has changed. See this FAQ.

Alerts service shouldn't use nsDependentString to convert an nsAString to an nsString

RESOLVED FIXED in mozilla8

Status

()

Core
IPC
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Edgar Flores)

Tracking

Trunk
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=jdm], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
It also uses nsAutoString as a conversion, which is probably overkill; nsString or possibly PromiseFlatString should work, depending on how the string is used.

Comment 1

6 years ago
The relevant code is here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/nsAlertsService.cpp#87

I think using PromiseFlatString should be fine here, since the data just ends up being copied into another nsString inside the AlertObserver constructor.
Whiteboard: [good first bug]

Updated

6 years ago
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
(Assignee)

Comment 2

6 years ago
Created attachment 551235 [details] [diff] [review]
per suggestion changed nsDependentString to PromiseFlatString
(Assignee)

Comment 3

6 years ago
I have a question. How are reviewers found? Is there a list for a specific section of the repository?
(Reporter)

Comment 4

6 years ago
Comment on attachment 551235 [details] [diff] [review]
per suggestion changed nsDependentString to PromiseFlatString

Mossop said that I could review this.
Attachment #551235 - Flags: review+

Updated

6 years ago
Assignee: nobody → edgarf2002
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
http://hg.mozilla.org/mozilla-central/rev/7b8aff23b029
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jdm][inbound] → [good first bug][mentor=jdm]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.