It also uses nsAutoString as a conversion, which is probably overkill; nsString or possibly PromiseFlatString should work, depending on how the string is used.
The relevant code is here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/nsAlertsService.cpp#87 I think using PromiseFlatString should be fine here, since the data just ends up being copied into another nsString inside the AlertObserver constructor.
Created attachment 551235 [details] [diff] [review] per suggestion changed nsDependentString to PromiseFlatString
I have a question. How are reviewers found? Is there a list for a specific section of the repository?
Comment on attachment 551235 [details] [diff] [review] per suggestion changed nsDependentString to PromiseFlatString Mossop said that I could review this.