Closed Bug 624740 Opened 9 years ago Closed 8 years ago

Alerts service shouldn't use nsDependentString to convert an nsAString to an nsString

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: neil, Assigned: edgarf2002)

References

()

Details

(Whiteboard: [good first bug][mentor=jdm])

Attachments

(1 file)

It also uses nsAutoString as a conversion, which is probably overkill; nsString or possibly PromiseFlatString should work, depending on how the string is used.
The relevant code is here:

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/alerts/nsAlertsService.cpp#87

I think using PromiseFlatString should be fine here, since the data just ends up being copied into another nsString inside the AlertObserver constructor.
Whiteboard: [good first bug]
Whiteboard: [good first bug] → [good first bug][mentor=jdm]
I have a question. How are reviewers found? Is there a list for a specific section of the repository?
Comment on attachment 551235 [details] [diff] [review]
per suggestion changed nsDependentString to PromiseFlatString

Mossop said that I could review this.
Attachment #551235 - Flags: review+
Assignee: nobody → edgarf2002
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jdm] → [good first bug][mentor=jdm][inbound]
http://hg.mozilla.org/mozilla-central/rev/7b8aff23b029
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jdm][inbound] → [good first bug][mentor=jdm]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.