If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Occurances of uninitialized variables being used before being set.

RESOLVED FIXED in mozilla0.9.3

Status

()

Core
Networking
P3
normal
RESOLVED FIXED
17 years ago
15 years ago

People

(Reporter: Rich Burridge, Assigned: dougt)

Tracking

Trunk
mozilla0.9.3
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
For more details on this problem, see:

http://bugzilla.mozilla.org/show_bug.cgi?id=59652

This bug is just for the warnings in various source files in the Networking
module:

nsMemCacheChannel.cpp:128: warning: `nsresult rv' might be used uninitialized in
this function
nsMemCacheChannel.cpp:144: warning: `nsresult rv' might be used uninitialized in
this function
----
nsMIMEService.cpp:89: warning: `nsresult rv' might be used uninitialized in this
function
----
nsUnknownDecoder.cpp:129: warning: `nsresult rv' might be used uninitialized in
../../../../dist/include/nsAReadableString.h:1085: warning: `int whichString'
might be used uninitialized in this function
----
nsHTTPResponseListener.cpp:837: warning: `nsresult rv' might be used
uninitialized in this function
----
nsJARChannel.cpp:172: warning: `nsresult rv' might be used uninitialized in this
function
----
(Reporter)

Updated

17 years ago
Blocks: 59652

Comment 1

17 years ago
Created attachment 19079 [details] [diff] [review]
Patch which fixes these warnings, sets rv = NS_OK.

Comment 2

17 years ago
Gagan, can I get you to review this patch?
Assignee: gagan → darin

Updated

17 years ago
Status: NEW → ASSIGNED

Comment 3

17 years ago
r=gagan

Comment 4

17 years ago
sr=mscott

Comment 5

17 years ago
Fixed this on the trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

17 years ago
Blocks: 60740
(Reporter)

Comment 6

17 years ago
Change also checked into the OEM branch.

Comment 7

17 years ago
mozilla/netwerk/streamconv/converters/nsFTPDirListingConv.cpp: In method `char
*nsFTPDirListingConv::DigestBufferLines (char *, nsCAutoString &)':
nsFTPDirListingConv.cpp:886: warning: `long unsigned int size' might be used
uninitialized in this function
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 8

17 years ago
-> dougt
Assignee: darin → dougt
Status: REOPENED → NEW
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.3
(Assignee)

Comment 9

17 years ago
Aleksey, I don;t see how size can be used unitialized.  It is being inited using
the 18th char of the linebuffer.  What compiler are you using?

Marking as Fixed since this bug morphed.  If you still think that this is a
problem, please file a seperate bug.
Status: NEW → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED

Comment 10

16 years ago
See bug 119220 for more warnings

Updated

15 years ago
QA Contact: tever → benc
You need to log in before you can comment on or make changes to this bug.