59661 - Occurances of uninitialized variables being used before being set.

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[Rich Burridge]

For more details on this problem, see:

http://bugzilla.mozilla.org/show_bug.cgi?id=59652

This bug is just for the warnings in various source files in the Networking
module:

nsMemCacheChannel.cpp:128: warning: `nsresult rv' might be used uninitialized in
this function
nsMemCacheChannel.cpp:144: warning: `nsresult rv' might be used uninitialized in
this function
----
nsMIMEService.cpp:89: warning: `nsresult rv' might be used uninitialized in this
function
----
nsUnknownDecoder.cpp:129: warning: `nsresult rv' might be used uninitialized in
../../../../dist/include/nsAReadableString.h:1085: warning: `int whichString'
might be used uninitialized in this function
----
nsHTTPResponseListener.cpp:837: warning: `nsresult rv' might be used
uninitialized in this function
----
nsJARChannel.cpp:172: warning: `nsresult rv' might be used uninitialized in this
function
----

Comment 1

[Darin Fisher]

Attachment: Patch which fixes these warnings, sets rv = NS_OK.

Comment 2

[Darin Fisher]

Gagan, can I get you to review this patch?

Comment 3

[Gagan]

r=gagan

Comment 4

[Scott MacGregor]

sr=mscott

Comment 5

[Darin Fisher]

Fixed this on the trunk.

Comment 6

[Rich Burridge]

Change also checked into the OEM branch.

Comment 7

[Aleksey Nogin]

mozilla/netwerk/streamconv/converters/nsFTPDirListingConv.cpp: In method `char
*nsFTPDirListingConv::DigestBufferLines (char *, nsCAutoString &)':
nsFTPDirListingConv.cpp:886: warning: `long unsigned int size' might be used
uninitialized in this function

Comment 8

[Darin Fisher]

-> dougt

Comment 9

[Doug Turner (:dougt)]

Aleksey, I don;t see how size can be used unitialized.  It is being inited using
the 18th char of the linebuffer.  What compiler are you using?

Marking as Fixed since this bug morphed.  If you still think that this is a
problem, please file a seperate bug.

Comment 10

[Aleksey Nogin]

See bug 119220 for more warnings