596619 - panning the page during findbar use shouldn't dismiss the findbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

The findbar (find in page) should not disappear just because a user is panning the page.  Quite often the user will have to pan the page to see the context of what the findbar has found.  The keyboard can certainly be dimissed, but the findbar should remain so that the user can keep finding, and can refocus the field to bring the keyboard back up.  Only tapping off of the findbar should dismiss it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

As an aside, I don't think the Form Assistant should disappear when panning either. Just mentioning since these "bars" are related in code.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch prevent the Find Helper to be considered as a popup. The patch also include a fix for getting the coordinate of the selection when it is in a sub-document, and an another one for not showing the title bar on some cases.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 477137 [details] [diff] [review]
Patch


>diff -r 5860ea9d73d5 chrome/content/content.js
>   receiveMessage: function findHandlerReceiveMessage(aMessage) {
 
>-    let controller = this._selectionController.getSelection(Ci.nsISelectionController.SELECTION_NORMAL);
>-    if (!controller.rangeCount) {
>+    let selection = this._fastFind.currentWindow.getSelection();
>+    if (!selection.rangeCount) {

Add a comment above this block to let us know what this code is trying to do
 
>-    let range = controller.getRangeAt(0);
>     let scroll = Util.getScrollOffset(content);
>-    let rect = range.getBoundingClientRect();
>-    rect = new Rect(scroll.x + rect.left, scroll.y + rect.top, rect.width, rect.height);
>+    for (let frame = this._fastFind.currentWindow; frame != content; frame = frame.parent) {
>+      let rect = frame.frameElement.getBoundingClientRect();
>+      let left = frame.getComputedStyle(frame.frameElement, "").borderLeftWidth;
>+      let top = frame.getComputedStyle(frame.frameElement, "").borderTopWidth;
>+      scroll.add(rect.left + parseInt(left), rect.top + parseInt(top));
>+    }

Add some comments here too

>+    let rangeRect = selection.getRangeAt(0).getBoundingClientRect();
>+    let rect = new Rect(scroll.x + rangeRect.left, scroll.y + rangeRect.top, rangeRect.width, rangeRect.height);

And here, just to complete the function

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/9ee2a7cc7120

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b6pre) Gecko/20100930 Namoroka/4.0b7pre Fennec/4.0b1pre

Follow up bugs filed: 600844 , 600845, 600846