600441 - [regression] Escape key goes back in history when Form Helper is opened

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Form Helper is not a popup anymore (and so will be Find Helper in a few) and because of this if VK_ESCAPE is called we're going back in history instead of dismissing the helper.

Steps to reproduce:
 * launch fennec
 * go to google.fr
 * click on the google's textbox
 * hit the back arrow of your Android device hardware keyboard or hit ESC on desktop

Actual results:
 * fennec goes one page back into history and dismiss the form helper

Expected results:
 * fennec dismiss the form helper

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 479271 [details] [diff] [review]
Patch

Man, the handleEscape method is ever growing...

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> Comment on attachment 479271 [details] [diff] [review]
> Patch
> 
> Man, the handleEscape method is ever growing...

yeah, this is moslty because the way we handle popups, dialogs, panels, ... sucks. At some point (after 2.0) we need to do some code cleanup and find a new way of doing it :(

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d4a5faa2a8eb

Comment 4

[Cristian Nicolae (:xti)]

Form Helper feature is not available anymore on the latest Nightly build.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110912
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2