596620 - Remove compat code for username-based UI

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Bug 595066 landed in m-c which means we can remove the backwards compatibility code for username-based UIs in services/sync/

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Mike Connor [:mconnor]]

Well, we can only remove this from the add-on if users of older beta versions upgrade.  Because we can't have multiple compatibility ranges for an add-on, we can't exclude older betas like this.

Comment 3

[Philipp von Weitershausen [:philikon]]

Not sure I understand. How would this affect users of older betas? This is backwards compat code that is no longer used by neither the add-on UI nor the Firefox UI.

Comment 4

[Mike Connor [:mconnor]]

The b4 UI will use the new backend, and fail.

Comment 5

[Philipp von Weitershausen [:philikon]]

Hrm, so I guess we won't be able to remove this until we require minVersion=4.0?

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 476028 [details] [diff] [review]
v1

Yeah, precisely.  Clearing request, we'll revisit in January.

Comment 7

[Richard Newman [:rnewman]]

Time to revisit?

Comment 8

[Philipp von Weitershausen [:philikon]]

Comment on attachment 476028 [details] [diff] [review]
v1

Yup!

Comment 9

[Richard Newman [:rnewman]]

Comment on attachment 476028 [details] [diff] [review]
v1

Tested connecting to a username account; works. I'd r+, but:

TEST-UNEXPECTED-FAIL | /Volumes/HDD/build/services-central/obj-ff-dbg/_tests/xpcshell/services/sync/tests/unit/test_utils_getErrorString.js | false == true - See following stack:
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_throw :: line 439
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_check_eq :: line 491
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_check_true :: line 503
JS frame :: /Volumes/HDD/build/services-central/obj-ff-dbg/_tests/xpcshell/services/sync/tests/unit/test_utils_getErrorString.js :: run_test :: line 10
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: _execute_test :: line 322

Comment 10

[Richard Newman [:rnewman]]

Attachment: v2

Fixed test.

Comment 11

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/services/services-central/rev/a8551b4ae9f0

Comment 12

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/a8551b4ae9f0