Closed Bug 596620 Opened 9 years ago Closed 9 years ago

Remove compat code for username-based UI

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: philikon, Assigned: philikon)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Bug 595066 landed in m-c which means we can remove the backwards compatibility code for username-based UIs in services/sync/
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → philipp
Attachment #476028 - Flags: review?(mconnor)
Well, we can only remove this from the add-on if users of older beta versions upgrade.  Because we can't have multiple compatibility ranges for an add-on, we can't exclude older betas like this.
Not sure I understand. How would this affect users of older betas? This is backwards compat code that is no longer used by neither the add-on UI nor the Firefox UI.
The b4 UI will use the new backend, and fail.
Hrm, so I guess we won't be able to remove this until we require minVersion=4.0?
Comment on attachment 476028 [details] [diff] [review]
v1

Yeah, precisely.  Clearing request, we'll revisit in January.
Attachment #476028 - Flags: review?(mconnor)
Time to revisit?
Comment on attachment 476028 [details] [diff] [review]
v1

Yup!
Attachment #476028 - Flags: review?(rnewman)
Comment on attachment 476028 [details] [diff] [review]
v1

Tested connecting to a username account; works. I'd r+, but:

TEST-UNEXPECTED-FAIL | /Volumes/HDD/build/services-central/obj-ff-dbg/_tests/xpcshell/services/sync/tests/unit/test_utils_getErrorString.js | false == true - See following stack:
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_throw :: line 439
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_check_eq :: line 491
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: do_check_true :: line 503
JS frame :: /Volumes/HDD/build/services-central/obj-ff-dbg/_tests/xpcshell/services/sync/tests/unit/test_utils_getErrorString.js :: run_test :: line 10
JS frame :: /Users/rnewman/moz/hg/services-central/testing/xpcshell/head.js :: _execute_test :: line 322
Attached patch v2Splinter Review
Fixed test.
Attachment #476028 - Attachment is obsolete: true
Attachment #521745 - Flags: review+
Attachment #476028 - Flags: review?(rnewman)
Whiteboard: [fixed in services] → [fixed in services][qa-]
http://hg.mozilla.org/mozilla-central/rev/a8551b4ae9f0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla5
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.