597188 - application closes when "undo close group" is up and you go into private browsing mode

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[juan becerra [:juanb]]

While testing the latest nightly build, I noticed that Firefox would close when I went into private browsing mode using ctrl-shift-p while there was an "undo close group" button present in Panorama view.

After successive tries, I got a session restore page, so this could be a crash, except it doesn't trigger the crash reporter. CC'ing Ted.

Steps:

1. Open a window with 3 tabs
2. Go into Panorama
3. Create a new group and drag two of the 3 tabs into it
4. Close the new group by licking on its X
5. While the "undo close group" button is there, press ctrl-shift-p to into private browsing mode

Expected: All thumbnails disappear and you get a single tab in PB mode

Actual: After a couple of seconds the application disappears (or perhaps it crashes).

When you relaunch the app and go into panorama, it's often in a weird state.

Comment 1

[(not currently active) Ted Mielczarek]

If this is on Windows, and you're not getting the Mozilla Crash Reporter dialog or the Windows Error Reporting dialog, it's unlikely to be a crash. More likely the app is just quitting unexpectedly (but exiting cleanly).

Comment 2

[(no longer active)]

What if you have another window open, like the Downloads window, for example?

Comment 3

[juan becerra [:juanb]]

I'm trying it now, and the application does not close (wth?). However, the window does close. After step 5 in comment #0, the Panorama view window stays open for as long as the "Undo Close Group" button is open. When the button goes away so does the window.

So, for whatever reason, the application isn't closing now. Still, there's some oddness there, that should be captured in a different bug. I'll try in Windows 7, just to make sure.

In this screencast I followed the reproduction steps, but the application did not close. After the window closed, I opened a new tab, and then I restarted the app to bring back my tabs.

http://screencast.com/t/NjkyMGJjZm

Comment 4

[juan becerra [:juanb]]

Meh, I tried reproducing the problem on Mac, when I should have been trying on Windows 7, as reported. Trying now.

Comment 5

[juan becerra [:juanb]]

I double checked in Windows 7, and the application closes when I have a single window (no taskbar icons), but stays open when I have the Downloads window open. See: http://screencast.com/t/ZDE4YjEzNTk

Comment 6

[aravindm]

Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20101004 Firefox/4.0b7pre

Able to reproduce in Windows XP also. After step 5, firefox closes without any error. When firefox is restarted, it opens all the 3 tabs in the main window. Firefox window does not close when downloads window is open when entering in PB mode.

Comment 7

[timeless]

juanb, please use:
https://developer.mozilla.org/En/How_to_get_a_stacktrace_with_WinDbg

install and use the 32bit version of windbg

Comment 8

[Raymond Lee [:raymondlee]]

The patch for bug 595521 should also fix the application closes issue

Comment 9

[Ian Gilman [:iangilman]]

bug 595521 has landed, so this should be fixed as well; please verify.

Comment 10

[Tracy Walker [:tracy]]

Verified on minefield nightly build of 20101112