597237 - "Paste & Go" should turn into "Paste & Search" when contents of the clipboard aren't a URI

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Justin Lebar (not reading bugmail)]

Typing a non-URI into the location bar now does a search.  "Paste & Go"ing a non-URI into the location bar therefore does a search.This action should be labeled in the menu bar as "Paste & Search", not "Paste & Go".

Comment 1

[Frank Yan (:fryn)]

Given that our location bar and search box are deliberately kept separate, I don't think this is necessary. Note that we display the Go button with a tooltip of 'Go to the address in the Location Bar' regardless of the location bar's input.

If we were to unify the two input boxes, then we absolutely should do this.

Comment 2

[Justin Lebar (not reading bugmail)]

> Given that our location bar and search box are deliberately kept separate, I> don't think this is necessary.If the location bar didn't do searches, then I'd suggest disabling "paste & go" when there wasn't a URI on the clipboard.  But given that the location bar now does searches, I don't think "go" is the right verb.> Note that we display the Go button with a> tooltip of 'Go to the address in the Location Bar' regardless of the location> bar's input.I think that's also a bug.

Comment 3

[Justin Lebar (not reading bugmail)]

Agh.  I'm sorry about the misformatted comment.  Bug 596752.  Trying again.

> Given that our location bar and search box are deliberately kept separate, I
> don't think this is necessary.

If the location bar didn't do searches, then I'd suggest disabling "paste & go" when there wasn't a URI on the clipboard.  But given that the location bar now does searches, I don't think "go" is the right verb.

> Note that we display the Go button with a
> tooltip of 'Go to the address in the Location Bar' regardless of the location
> bar's input.

I think that's also a bug.

Comment 4

[ithinc]

The location bar doesn't do searches. It's URI fix-up.

Comment 5

[Justin Lebar (not reading bugmail)]

(In reply to comment #4)
> The location bar doesn't do searches. It's URI fix-up.

That's now incorrect.  Try typing "kitties" into your location bar.  You're taken to a Google result page, not kitties.com.

Comment 6

[Dominic]

This is [parity-chrome], since it's the same behavior.

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Philipp, how do you feel about this? The duplicate bug has even more ideas.

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Yeah, the suggested behavior does make sense.
Given how hidden this UI is (and that »Go« is a pretty universal word), I wouldn't put it near the top of the priority list though.

Comment 10

[Will]

I think search engine partners would care about this. Also, every major browser does this, even Edge and Safari for iOS!

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to (Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo from comment #9)
> Given how hidden this UI is (and that »Go« is a pretty universal word), I
> wouldn't put it near the top of the priority list though.

My thoughts exactly.

Comment 12

[BugBot [:suhaib / :marco]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 597237: Change the paste-and-go menuitem label to 'Paste and Search' if the content of clipboard is not URL

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa19e15b43da
https://hg.mozilla.org/integration/autoland/rev/6ff5dc2c3cd2
Change the paste-and-go menuitem label to 'Paste and Search' if the content of clipboard is not URL r=urlbar-reviewers,Standard8,fluent-reviewers,flod

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6ff5dc2c3cd2

Comment 16

[Donal Meehan [:dmeehan]]

Did you want to nominate this for the Fx160 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

The address bar context menu now shows "Paste and Search" instead of "Paste and Go" when the copied text is a search term rather than a web address.

Comment 17

[Daisuke Akatsuka (:daisuke)]

Thanks, I will do it!

Comment 18

[Daisuke Akatsuka (:daisuke)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Long standing request. The "Paste and Go" label was misleading when the clipboard contains search terms.
[Affects Firefox for Android]: No
[Suggested wording]: The address bar context menu now shows "Paste and Search" instead of "Paste and Go" when the copied text is a search term rather than a web address.
[Links (documentation, blog post, etc)]:

Comment 19

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx160 nightly release notes, please allow 30 minutes for the site to update. This will carry over to the Fx160 beta release notes and eventually the Fx160 release notes.