597294 - Keyboard shortcut for TabCandy not shown in View menu

Status: RESOLVED DUPLICATE of bug 597761

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Sean Dunn]

This is a new bug from 579197, at the request of Mitcho.

Steps:
1. In the browser, hit Alt to bring up the main menu
2. Click View
3. Locate Group Tabs... item
4. Notice there is no keyboard combo

Expected:
The ctrl-space keyboard combo shown for Group Tabs...
The Win7 build (most likely windows in general) does not show the key combo under "View->Group Tabs...".

Comment 1

[Erik Vold]

So I tried doing this, and when modifiers="alt" (for mac) and keycode="VK_SPACE" nothing was shown in the view menu, when I changed keycode="VK_SPACE" to key="Q" then the keyboard combo was shown. So I wonder if Firefox just doesn't display the shortcut in a menuitem when keycode="VK_SPACE". We could use the keytext attribute to manually input the shortcut shown though..

To be clear for mac one should use: modifiers="alt" keycode="VK_SPACE"
and everything else: modifiers="accel" keycode="VK_SPACE"
correct?

Also could someone kindly point me to where the hotkey is currently registered/added?

Comment 3

[Ian Gilman [:iangilman]]

(In reply to comment #1)
> Also could someone kindly point me to where the hotkey is currently
> registered/added?

TabView._setBrowserKeyHandlers() in /browser/base/content/browser-tabview.js