5974 - View | Page source should display Japanese with META charset

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Teruko Kobayashi]

Tested 5-5-6 Win32 build.

Now the menu View| Page source is enabled, but it does not display Japanese characters.

Comment 1

[Frank Tang]

The problem is we does not pass the charset information to the new window. We
should pass the default charset value as well as the current charset to the new
WebShell.Make it M8

Comment 2

[bobj]

Frank will probably be out on paternity leave during M8.  Moved to M9.

Comment 3

[Frank Tang]

move to M10

Comment 4

[Frank Tang]

changr back to M9

Comment 5

[Frank Tang]

change the summary from "View | Page source should display Japanese characters"
to "View | Page source should display Japanese characters when the page have
META charset"
What happened is CViewSourceHTML didn't hanld META charset as CNavDTD does.
Reassign this to harishd. I will open a seperate bug for the case of default
charset and assign that one to myself.

harishd, can you make it for M11? Let me know your estimatation first . Thanks.

Comment 6

[harishd]

This shouldn't take too long.  I'll try to get it in for M10.

Setting milestone to M10.

Comment 7

[harishd]

Added ftang to the CC list.

Comment 8

[harishd]

Attachment: Frank, this put this patch in CViewSourceHTML::HandleToken() [ nsViewsourceHTML.cpp ], under "case eToken_start:"

Comment 9

[harishd]

Reassingning bug to [e-mail].

Comment 10

[Frank Tang]

fixed and check in
Now we pass the parser command to webshell...

Comment 11

[Frank Tang]

break by vidure since he change the line cmd to "view" in nsWebShell.cpp line
193x.

vidure, please back out that line (change "view" back to cmd to fix it.

Comment 12

[vidur (gone)]

Sorry, Frank. Restored Franks change that was lost during my merge and checkin
late last week.

Comment 13

[Teruko Kobayashi]

I verified as fix in 9-23-08 Mac and Windows.  I cannot verify in Linux due to
the bug 14802.

Comment 14

[Teruko Kobayashi]

I verified this in 9-29 Linux build.