597927 - border-radius doesn't properly clip the corners of a child that scrolls

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

When an element has a border-radius, and has a child element that scrolls, the corners of that child element aren't clipped. Instead, the corners cover up the rounded part of its parent's border.

See bug 595656 and its screenshot (https://bugzilla.mozilla.org/attachment.cgi?id=474530) for an example of this.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note: also happens when the child is a xul:browser element, ragardless of whether it has a scroll box or not.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's supposed to do this if the element with 'border-radius' has 'overflow'!='visible'.  Does setting overflow:hidden fix this?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Somewhere between worksforme and invalid, I think.  (But please do respond if comment 2 doesn't fix it.)

Comment 4

[Dave Townsend [:mossop]]

Setting overflow:hidden does not fix it. Could this be a problem because it is an XUL deck?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems like the deck frame construction is SIMPLE_XUL_INT_CREATE rather than SCROLLABLE_XUL_INT_CREATE.  Deck is pretty similar to stack, though, which is scrollable.

Does 'overflow: hidden' solve your problem if, in nsCSSFrameConstructor::FindXULDisplayData (in layout/base/nsCSSFrameConstructor.cpp), you change SIMPLE_XUL_INT_CREATE to SCROLLABLE_XUL_INT_CREATE for the line with NS_NewDeckFrame in it?

Comment 6

[Dave Townsend [:mossop]]

(In reply to comment #5)
> Seems like the deck frame construction is SIMPLE_XUL_INT_CREATE rather than
> SCROLLABLE_XUL_INT_CREATE.  Deck is pretty similar to stack, though, which is
> scrollable.
> 
> Does 'overflow: hidden' solve your problem if, in
> nsCSSFrameConstructor::FindXULDisplayData (in
> layout/base/nsCSSFrameConstructor.cpp), you change SIMPLE_XUL_INT_CREATE to
> SCROLLABLE_XUL_INT_CREATE for the line with NS_NewDeckFrame in it?

That does work (though it breaks the deck's operation). However you've clued me into an alternative solution. I can just wrap the deck in a <box> and put the borders on that which works because boxes are constructed with SCROLLABLE_XUL_INT_CREATE. So I don't think this is going to be necessary now.