Last Comment Bug 597994 - Make removing entries in Data Manager trees select the next entry
: Make removing entries in Data Manager trees select the next entry
Product: SeaMonkey
Classification: Client Software
Component: Passwords & Permissions (show other bugs)
: Trunk
: All All
-- normal (vote)
: seamonkey2.1b2
Assigned To: Robert Kaiser
Depends on: DataManager
Blocks: 599097
  Show dependency treegraph
Reported: 2010-09-20 05:32 PDT by Robert Kaiser
Modified: 2010-11-18 06:47 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

update selection after deleting (7.62 KB, patch)
2010-11-10 14:40 PST, Robert Kaiser
iann_bugzilla: review+
Details | Diff | Splinter Review

Description User image Robert Kaiser 2010-09-20 05:32:04 PDT
From bug 569341 (Ian's comment, my reply, his reply):
> > When you use the delete key to remove cookies, the next cookie in the list is
> > not selected and you can not use the delete key until you select another
> > cookie.
> Hmm, interesting idea, might really be helpful. Can I pass that into a
> followup, please?
I guess so, but less obvious candidate than first one.

When done, this should be done for all tree views in the Data Manager.
Comment 1 User image Robert Kaiser 2010-11-10 14:40:11 PST
Created attachment 489626 [details] [diff] [review]
update selection after deleting

Here's a patch that updates the selection after delete on all the trees we have in Data Manager and also updates the test to not fail and additionally check for the correct results from this patch.
Comment 2 User image Ian Neal 2010-11-17 16:33:29 PST
Comment on attachment 489626 [details] [diff] [review]
update selection after deleting

Lots of similar code, but as discussed on IRC not quite worth a helper function (yet) r=me
Comment 3 User image Robert Kaiser 2010-11-18 06:47:25 PST
Landed as

Note You need to log in before you can comment on or make changes to this bug.