598023 - New Tabs get stuck in Closed Tab list when first tab is a "New Tab" and is closed

Status: RESOLVED DUPLICATE of bug 581937

(Firefox :: Session Restore, defect)

Description

[Michael Kraft [:morac]]

If there is a "New Tab" displaying as the first tab and it's closed, that tab gets stuck in the closed tab list.  It can be restored, but it will remain in the closed tab list.

The easiest way to demonstrate this is to close all the tabs in a window and then close the first (and only) tab a bunch of times.  Each time the first tab is closed another "New Tab" is generated.  All these new tabs become stuck in the Closed tab list.

I don't think "New Tab"s should be being added to the closed tab list anyway since they have no state.

works 20100723 nightly
broken 20100724 nightly

Likely caused by bug 580819.  Note that this and bug 580819 are similar but this is more generic and that is more specific.  Fixing this will likely fix bug 580819.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Sounds a lot like bug 581937 but in different words... That is a known regression from bug 580819. Would you mind confirming/denying that? I get the feeling you meant 581937 in your last 2 bug refs above.

Comment 2

[Michael Kraft [:morac]]

I actually meant bug 582701 but all of those are probably the same problem.

Comment 3

[Johnathan Nightingale [:johnath]]

Hmm - on mac I see those tabs in the list, but they don't get stuck - restoring them subtracts them from the menu in the way I'd expect. Still a problem for you, Michael?

Comment 4

[Michael Kraft [:morac]]

Yes, it's still a problem, but only if there is only one tab open and it's blank.  If I open a second blank tab or load a page into the first (and only) blank tab, then closed tabs restore as usual.  

Also oddly enough in the case of only 1 blank tab, I can get these tabs by holding down the CTRL-SHIFT-T key (restores the last closed tab).  This will restore the new tabs.  It actually restores more tabs then was closed for whatever reason.   If I press and release CTRL-SHIFT-T to restore one tab at a time, it never restores.

So basically the work around is to open another tab (or load a page) and then restore the blank tabs.

Comment 5

[Dietrich Ayala (:dietrich)]

Do those entries persist across restarts? (ie, is it a problem w/ the stored data, or just the UI?)

If it's just the UI, this should not block, given how improbable the scenario is for most users.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(Agreed, renominate if it's a problem with the stored data)

Comment 7

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to comment #6)
> (Agreed, renominate if it's a problem with the stored data)

Looks to be a problem with the stored data.