598206 - test-panel.testSeveralShowHides timeout

Status: RESOLVED DUPLICATE of bug 598137

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

On all primary platforms with Firefox 4.0b6, I see a consistent timeout in test-panel.testSeveralShowHides, f.e.:

--------------------------------------------------------------------------------
(jsdk)myk@myk:~/Projects/jsdk/packages/jetpack-core$ cfx test -b ~/Applications/firefox-4.0b6/firefox -F panel --verbose
Using binary at '/home/myk/Applications/firefox-4.0b6/firefox'.
Using profile at '/tmp/tmpuN8_MV.mozrunner'.

(firefox-bin:11283): GLib-WARNING **: g_set_prgname() called multiple times
info: executing 'test-panel.testPanel'
info: pass: The panel was loaded.
info: executing 'test-panel.testShowHidePanel'
info: pass: The panel was shown.
info: pass: The panel was hidden.
info: executing 'test-panel.testHideBeforeShow'
info: pass: must not emit show if was hidden before
info: executing 'test-panel.testSeveralShowHides'
error: TEST FAILED: test-panel.testSeveralShowHides (timed out)
info: executing 'test-panel.testContentURLOption'
info: pass: contentURL accepts a string URL.
info: pass: contentURL is a URL object.
info: pass: contentURL stringifies to the string to which it was set.
info: pass: contentURL accepts a URL object.
info: pass: contentURL is a URL object.
info: pass: contentURL stringifies to the URL to which it was set.
info: pass: contentURL accepts a data: URL.
info: pass: contentURL is undefined.
info: pass: Panel throws an exception if contentURL is not a URL.
info: executing 'test-panel.test:destruct before removed'

13 of 15 tests passed.

The following tests failed:
  test-panel.testSeveralShowHides: timed out
  test-panel.test:destruct before removed: empty test

FAIL
Total time: 13.411432 seconds
Program terminated unsuccessfully.
--------------------------------------------------------------------------------
The "test-panel.test:destruct before removed: empty test" failure is bug 598137, which may be related, as they occur together.

Irakli: any thoughts on this one?

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Can you please try with increased timeout, let's say 200 or 300 instead, and let me know if timeout still observed. 

http://github.com/Gozala/jetpack-sdk/blob/widget-test%40596666/packages/jetpack-core/tests/test-panel.js#L160

Comment 2

[Dietrich Ayala (:dietrich)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=596666#c13. Timeouts r bad.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to comment #2)
> See https://bugzilla.mozilla.org/show_bug.cgi?id=596666#c13. Timeouts r bad.

Yes I do agree they are bad but, I did not found any better option. What happens is that tests running dialog gets open once it can kick in which prevents panel form opening since focus got lost. Switching windows focus won't actually help since dialog will kick just before panel is open. I thing best wold be to change test runner so that it opens dialog before running tests instead of opposite.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Even though it's not really a duplicate I'm marking it as one since 598137 issue was caused by the same bug and fix was attached to 598137.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".