598256 - Stop shipping the nearly-useless comm.jar already

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Patch on top of bug 595750

comm.jar contains only two things: the xbl-marquee support files, and some sort of XUL cookie dialogue files.  There's no reason to ship a jar file that's half useless (and which was eliminated in the Great Jar Purge of Gecko 2 anyway), and fewer jars equals less I/O and better performance (or that was the premise of the Great Jar Purge of Gecko 2, anyway).

This patch, which depends on the one for bug 595750, adds xbl-marquee packaging and registration to geckochrome's jar.mn and packages those files in toolkit.jar.

(There's some additional cleanup of style and existing comments I want to do to that file--I got sloppy with my spacing at one point--but I didn't want to roll that into this patch for future-blame-sanity reasons.  I can't make an additional patch on top of this one without either figuring out the mysterious mq or horking my tree, so it will have to come in a follow-up once either bug 595750 or both of these have landed.)

And yes, I did test a <marquee> with this patch.  It's still as annoying as ever. :P

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: jar.mn cleanup (patch on top of attachment 477043)

Actually, I can make a local copy and do a local diff to do the cleanup (it's a bigger bit of a hack than the hack to get two levels of changes beyond what's committed, but it saves me remembering to do the cleanup later, and a new bug, and the additional review process for the silly cleanup).

This fixes the spacing of the left columns to all align as they should, plus unifies comments as "Gecko 2" since 1.9.3 is no more.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 477226 [details] [diff] [review]
jar.mn cleanup (patch on top of attachment 477043 [details] [diff] [review])

And, once again, the "diff" and whatever views of this patch are broken because of the ++ stuff and bug 233695; use the "view" or "edit" views :(

Comment 3

[Stuart Morgan]

Comment on attachment 477043 [details] [diff] [review]
Patch on top of bug 595750

sr=smorgan

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/252007faaa8c for the comm.jar killing
http://hg.mozilla.org/camino/rev/1754e224353a for the cleanup