599042 - Build "Upload a New File" popup

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

Mockup: The very bottom of http://people.mozilla.com/~chowse/drop/amo/devtools/v2/Addon_05_Versions_Edit.png

Backend:
- This needs to accept a file for an add-on and kick off a validation job.  jbalogh and dd have code for this

Frontend:
- potch has some fancy new reusable popup code
- If there isn't a "validation report" page by the time this bug is done (and there probably won't be) add a TODO link there and file another bug to connect them.

CCing Chowse to figure out where the "What is validation?" link goes to.   Also, I'm assuming we're using spinners while it uploads and is validated?  Are we doing upload progress on this pane?  What happens when the file is uploaded and validated - the popup is still there and still says "Add File".

Comment 1

[Chris Howse [:chowse]]

FYI, updated mocks and workflows:

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/05_versions.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/06_versions_add.png
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/07_versions_edit.png

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon.pdf
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction.pdf

Comment 2

[Chris Howse [:chowse]]

(In reply to comment #0)
> CCing Chowse to figure out where the "What is validation?" link goes to.  

Do we have a FAQ entry or developer doc page about validation? That is where I imagined the link leading. If not, there probably should be one.


> Also, I'm assuming we're using spinners while it uploads and is validated?  

Yes. Some mocks have progress bars, but I can simplify that if they upload time is relatively short.

> Are we doing upload progress on this pane?

Yes. See the add-on upload workflow in:
http://people.mozilla.com/~chowse/drop/amo/devtools/v3/interaction/addon_upload.png


>  What happens when the file is uploaded
> and validated - the popup is still there and still says "Add File".

Sorry, wasn't clear in the mock-up. Initially, that 'Add File' button should be disabled, like it is during add-on submission. Once the upload and validation is complete, that button becomes enabled. This gives the user the options of reviewing any validation errors, or uploading a file again.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #2)
> (In reply to comment #0)
> > CCing Chowse to figure out where the "What is validation?" link goes to.  
> 
> Do we have a FAQ entry or developer doc page about validation? That is where I
> imagined the link leading. If not, there probably should be one.

https://addons.mozilla.org/en-US/firefox/pages/validation

Comment 4

[Justin Scott [:fligtar]]

intro paragraph for upload modal:

Files added to reviewed versions must be reviewed before they will be available for download.

Comment 5

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/7e7fbc60bca68a2c7234a3057105e1989246c31c