599173 - [autoconfig] Account Creation should work when offline

Status: NEW

(Thunderbird :: Account Manager, defect)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Steps to Reproduce:
1. Go Offline (i.e. turn off Wifi or unplug ethernet)
2. File->New->Mail Account ...
3. Enter Name, Email, Password and click Continue
4. You will receive the following exception:
"
[Exception... "Component returned failure code: 0x804b0010 (NS_ERROR_OFFLINE) [nsISocketTransportService.createTransport]"  nsresult: "0x804b0010 (NS_ERROR_OFFLINE)"  location: "JS frame :: chrome://messenger/content/accountcreation/guessConfig.js :: SocketUtil :: line 1071"  data: no]"
and you won't be able to create a Thunderbird email account manually

Comment 1

[WADA:World Anti-bad-Duping Agency]

Can we dup your bug to bug 583602?

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

oops yes this is a duplicate, i missed bug 583602, my apologies, marking as duplicate

Comment 3

[Ben Bucksch (:BenB)]

REOPENing, because this bug is better stated.

Comment 4

[Ben Bucksch (:BenB)]

Some fix has been made in bug 583602, but that fix only works when the necko offline detection works, and even then is suboptimal. This bug shall be able to fix it better, which should be:

1. When we make a network connection to contact the ISPDB *, and there is no Internet connection, we will get back a certain error code. We actually do pass that back to emailWizard.js already. All we need to do is catch that specific error situation.
2. Show a warning "
It appears that you are not offline, i.e. not connected to the Internet, because we can't reach the configuration server. In order to get the best configuration and be able to verify it, please go online before setting up an account. If for some reason that is impossible, you can manually enter the configuration and finish by clicking "Advanced config", but that is not recommended.

Please go online.
[I cannot go online] [I will connect to Internet]
"
3. If the user says he can't go online, to straight to manual mode (as if configs failed) and allow to skip the "Re-Test", i.e. enable Advanced Config button after the user entered a syntactically valid hostname. I.e. the only change we need to do is to not force a "Re-Test" before enabling the "Advanced Config" button.

* Do not check at request do the ISP server, because that may well not exist and give similar errors. Error code from fetchhttp for "cannot reach DNS" and "cannot reach server" is -2, see
http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/fetchhttp.js#77 and #200

That should fix it. We need to undo the patch in bug 583602, too.

Comment 5

[Mark Banner (:standard8)]

Whilst we still want this, we're not going to actively drive it in at the moment.