599748 - Remove custom |def check_call()|, now that Python 2.4 is unsupported

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

{
/testing/mozmill/mozrunner-2.5.1/mozrunner/killableprocess.py
    * line 86 -- def check_call(*args, **kwargs):
}

Jeff, I'm not sure about this one.

{
/build/util.py
    * line 44 -- def check_call(*popenargs, **kwargs):
}

Ted, do you want to keep an empty/placeholder util.py?

Comment 1

[Jeff Hammel]

for mozrunner, it is a straight inclusion of the pypi version of mozrunner: http://pypi.python.org/pypi/mozrunner . As far as I know, mozrunner is still scheduled to support 2.4, so I see no reason to remove it from m-c.  By the same token, I see no reason not to remove it either.  ctalbert?

Comment 2

[(not currently active) Ted Mielczarek]

(In reply to comment #0)
> Ted, do you want to keep an empty/placeholder util.py?

No, you can just hg rm that file and fix the files that import it.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> http://pypi.python.org/pypi/mozrunner

Thanks for your answer.
Wrt this bug, this occurrence should be fixed, when times come, in upstream repository.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove 'util.py' [Checked in: Comment 12]

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

"approval2.0=?":
Trivial build utils cleanup, zero risk.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

Per bug 601207,
I'll push upload.py only;
client.py (+ util.py) needs to support v2.4 still.

Ted, please read discussion there in case you would want to file a bug to have client.py called from a more recent version in MXR case...

Comment 7

[Justin Wood (:Callek)]

(In reply to comment #6)
> Comment on attachment 478915 [details] [diff] [review]
> (Av1) Remove 'util.py'
> 
> Per bug 601207,
> I'll push upload.py only;
> client.py (+ util.py) needs to support v2.4 still.
> 
> Ted, please read discussion there in case you would want to file a bug to have
> client.py called from a more recent version in MXR case...

m-c client.py is not used for mxr nor for any buildbots, the c-c client.py is however, so this should still be good-to-go.

CC:ing justdave just incase my presumption about mxr is incorrect, though I would be shocked if so.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/ec1525343e0b

Comment 9

[:Gavin Sharp [email: [e-mail]]]

I backed out all the changesets in your push because they weren't approved.

Comment 10

[Serge Gautherie (:sgautherie)]

Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

(In reply to comment #9)
> I backed out all the changesets in your push because they weren't approved.

See discussion in bug 595756 :-<

Comment 11

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)
> I backed out all the changesets in your push because they weren't approved.

http://hg.mozilla.org/mozilla-central/rev/60ce967b4a96

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/2d69f47f25e5

Comment 13

[Serge Gautherie (:sgautherie)]

Ah, I just remembered bug 601207 :-/
Dave, could you check/confirm what the current MXR status is w.r.t. python version and this check-in?

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 15

[Mitchell Hentges [:mhentges] 🦀]

There's no longer a mozrunner-related check_call() function defined.