Open Bug 599748 Opened 9 years ago Updated 2 years ago

Remove custom |def check_call()|, now that Python 2.4 is unsupported

Categories

(Firefox Build System :: General, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

ASSIGNED
mozilla6

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

{
/testing/mozmill/mozrunner-2.5.1/mozrunner/killableprocess.py
    * line 86 -- def check_call(*args, **kwargs):
}

Jeff, I'm not sure about this one.

{
/build/util.py
    * line 44 -- def check_call(*popenargs, **kwargs):
}

Ted, do you want to keep an empty/placeholder util.py?
Flags: in-testsuite-
for mozrunner, it is a straight inclusion of the pypi version of mozrunner: http://pypi.python.org/pypi/mozrunner . As far as I know, mozrunner is still scheduled to support 2.4, so I see no reason to remove it from m-c.  By the same token, I see no reason not to remove it either.  ctalbert?
(In reply to comment #0)
> Ted, do you want to keep an empty/placeholder util.py?

No, you can just hg rm that file and fix the files that import it.
(In reply to comment #1)
> http://pypi.python.org/pypi/mozrunner

Thanks for your answer.
Wrt this bug, this occurrence should be fixed, when times come, in upstream repository.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #478915 - Flags: review?(ted.mielczarek)
Attachment #478915 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

"approval2.0=?":
Trivial build utils cleanup, zero risk.
Attachment #478915 - Flags: approval2.0?
Depends on: 601207
Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

Per bug 601207,
I'll push upload.py only;
client.py (+ util.py) needs to support v2.4 still.

Ted, please read discussion there in case you would want to file a bug to have client.py called from a more recent version in MXR case...
(In reply to comment #6)
> Comment on attachment 478915 [details] [diff] [review]
> (Av1) Remove 'util.py'
> 
> Per bug 601207,
> I'll push upload.py only;
> client.py (+ util.py) needs to support v2.4 still.
> 
> Ted, please read discussion there in case you would want to file a bug to have
> client.py called from a more recent version in MXR case...

m-c client.py is not used for mxr nor for any buildbots, the c-c client.py is however, so this should still be good-to-go.

CC:ing justdave just incase my presumption about mxr is incorrect, though I would be shocked if so.
Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/ec1525343e0b
Attachment #478915 - Attachment description: (Av1) Remove 'util.py' → (Av1) Remove 'util.py' [Checked in: Comment 8]
Attachment #478915 - Flags: approval2.0?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
No longer depends on: 601207
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
I backed out all the changesets in your push because they weren't approved.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

(In reply to comment #9)
> I backed out all the changesets in your push because they weren't approved.

See discussion in bug 595756 :-<
Attachment #478915 - Flags: approval2.0?
Attachment #478915 - Attachment description: (Av1) Remove 'util.py' [Checked in: Comment 8] → (Av1) Remove 'util.py' [Checked in: Comment 8]
Attachment #478915 - Flags: approval2.0? → approval2.0-
Attachment #478915 - Attachment description: (Av1) Remove 'util.py' [Checked in: Comment 8] → (Av1) Remove 'util.py'
(In reply to comment #9)
> I backed out all the changesets in your push because they weren't approved.

http://hg.mozilla.org/mozilla-central/rev/60ce967b4a96
Comment on attachment 478915 [details] [diff] [review]
(Av1) Remove 'util.py'
[Checked in: Comment 12]

http://hg.mozilla.org/mozilla-central/rev/2d69f47f25e5
Attachment #478915 - Attachment description: (Av1) Remove 'util.py' → (Av1) Remove 'util.py' [Checked in: Comment 12]
Ah, I just remembered bug 601207 :-/
Dave, could you check/confirm what the current MXR status is w.r.t. python version and this check-in?
Status: REOPENED → ASSIGNED
Depends on: 601207
Target Milestone: mozilla2.0b8 → mozilla6
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.