600005 - Tabs opened in the background are drawn at the wrong scale

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b7pre)Gecko/20100927 Firefox/4.0b7pre Fennec/2.0b1pre

Mozilla/5.0 (Android; Linux armv71; rv2.0b7pre) Gecko/20100927 Firefox/4.0b7pre Fennec/2.0b1pre

1. go to http://people.mozilla.com/~nhirata/html_tp/
2. long tap and open layout-test.html in a new tab
3. go to the tab control and look at the new tab

Expected: The red background fills the whole screen and the zoom level is higher
Actual: The red background only fills the upper left corner and the zoom level is low

Note:
1. if the web page is opened in the same tab, the zoom level is fine.
2. happens on Maemo/Android

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Maemo 5 GTK screenshot

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

getBoundingClientRect does not work for background (display:none) browsers.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

remove a debugging statement

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 478984 [details] [diff] [review]
patch v2

Perhaps putting the browsers in a <deck> is the answer for this. Let's stop hacking around hidden browsers.

I think Wes has a patch to put browsers in a deck. Bug 598331, IIRC

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

if you open a long web page such as google news, and then open about: in a new tab, then go back to the google news tab, the google news tab is at the wrong zoom level.

Based on the comments, this seems like the same core issue so I placed the notes here.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's coordinate patches here. Wes, would life be easier in bug 598331 if Matt added the <deck> support in this bug?

Comment 7

[Wesley Johnston (:wesj)]

I'm fine with it. It probably should have a more focused bug anyway.

Comment 9

[Matt Brubeck (:mbrubeck)]

Pushed this patch to beta 1 relbranch:
http://hg.mozilla.org/mobile-browser/rev/7b91493b311b

Not pushing this fix to trunk; waiting for bug 598997 instead.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 478984 [details] [diff] [review]
patch v2

yeah, I forgot to r+ this for the relbranch

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed on trunk by bug 598997

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I see other related issues: ie panning shows grey squares that do not get filled and font fuzziness, but the original issue with size is fixed:

Mozille/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko20101005 Firefox/4.0b7pre Fennec/4.0b1
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b7pre) Gecko/201001005 Firefox/4.0b7pre Fennec/4.0b1

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 602309 reported as regression.