Closed Bug 600101 Opened 9 years ago Closed 9 years ago

Panel close button should be hidden in Android

Categories

(Firefox for Android Graveyard :: General, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached patch Patch (obsolete) — Splinter Review
The right panel close button is unuseful on Android since we have the back button.
Attachment #478941 - Flags: review?(mark.finkle)
If we are removing this button from Android, I think we should position it correctly for Maemo: top-right, in the title banner.
I think eventually we also want a leftward-swipe to move back to the content pane; this makes sense to me, removes a button, all goodness.
I'll file a bug for leftward-swipe. We can target that for after Fennec 2.
Attached patch Patch (obsolete) — Splinter Review
Attachment #478941 - Attachment is obsolete: true
Attachment #479765 - Flags: review?(mark.finkle)
Attachment #478941 - Flags: review?(mark.finkle)
Comment on attachment 479765 [details] [diff] [review]
Patch

Removing review as seen on IRC, I will include a fix to keep the buttons on top
Attachment #479765 - Flags: review?(mark.finkle)
Attached patch Patch v0.2Splinter Review
Attachment #479765 - Attachment is obsolete: true
Attachment #479782 - Flags: review?(mark.finkle)
Attachment #479782 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/ce396f564ad1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Keeping the buttons on top seems to waste way too much space in landscape.
Can we make the heading line scroll, rather than staying fixed as it does now?  By "heading" I mean the blue "Preferences" line in this mockup:

http://www.flickr.com/photos/madhava_work/4993642838/in/set-72157624962763028/
(In reply to comment #9)
> Can we make the heading line scroll, rather than staying fixed as it does now? 
> By "heading" I mean the blue "Preferences" line in this mockup:

I find myself thinking the same thing. This means we would be moving the header into the list itself, which is easy. Also, I don't think we should have headers on all panels. Take add-ons for example. We already have a top row header in the list, "Your Add-ons", and I don't think we need the redundant "Add-ons" header as well.

Preferences does not currently have an in-list header row, so adding "Preferences" into the list seems ok to me.

(In reply to comment #8)
> Keeping the buttons on top seems to waste way too much space in landscape.

I hope removing the permanent header row helps this.

I'll file a bug and get Madhava to give feedback on it. Note, I don't want (or think we need) tiny labels under buttons either.
verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101001 Namoroka/4.0b7pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
Attached patch Update testsSplinter Review
This fixes some tests that were broken by this change.

I'm not sure why clicking the #tool-panel-close button stopped working, but we won't be able to do that when we run tests on Android, anyway.  We should probably get this working again on non-Android platforms, with some conditional logic in the test.
Attachment #480216 - Flags: review?(mark.finkle)
Attachment #480216 - Flags: review?(mark.finkle) → review+
Flags: in-litmus? → in-litmus?(aaron.train)
Unfamiliar with what used to exist. I'm assuming there simply used to exist a close button in the preferences panel for Fennec which is not needed anymore. FFT->Options (Preferences) should suffice?

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13631
Flags: in-litmus?(aaron.train) → in-litmus+
OS: Android → All
You need to log in before you can comment on or make changes to this bug.