600101 - Panel close button should be hidden in Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The right panel close button is unuseful on Android since we have the back button.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

If we are removing this button from Android, I think we should position it correctly for Maemo: top-right, in the title banner.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

I think eventually we also want a leftward-swipe to move back to the content pane; this makes sense to me, removes a button, all goodness.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I'll file a bug for leftward-swipe. We can target that for after Fennec 2.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 479765 [details] [diff] [review]
Patch

Removing review as seen on IRC, I will include a fix to keep the buttons on top

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/ce396f564ad1

Comment 8

[Michael Wu [:mwu]]

Keeping the buttons on top seems to waste way too much space in landscape.

Comment 9

[Matt Brubeck (:mbrubeck)]

Can we make the heading line scroll, rather than staying fixed as it does now?  By "heading" I mean the blue "Preferences" line in this mockup:

http://www.flickr.com/photos/madhava_work/4993642838/in/set-72157624962763028/

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #9)
> Can we make the heading line scroll, rather than staying fixed as it does now? 
> By "heading" I mean the blue "Preferences" line in this mockup:

I find myself thinking the same thing. This means we would be moving the header into the list itself, which is easy. Also, I don't think we should have headers on all panels. Take add-ons for example. We already have a top row header in the list, "Your Add-ons", and I don't think we need the redundant "Add-ons" header as well.

Preferences does not currently have an in-list header row, so adding "Preferences" into the list seems ok to me.

(In reply to comment #8)
> Keeping the buttons on top seems to waste way too much space in landscape.

I hope removing the permanent header row helps this.

I'll file a bug and get Madhava to give feedback on it. Note, I don't want (or think we need) tiny labels under buttons either.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Filed bug 601048

Comment 12

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b7pre) Gecko/20101001 Namoroka/4.0b7pre Fennec/4.0b2pre

Comment 13

[Matt Brubeck (:mbrubeck)]

Attachment: Update tests

This fixes some tests that were broken by this change.

I'm not sure why clicking the #tool-panel-close button stopped working, but we won't be able to do that when we run tests on Android, anyway.  We should probably get this working again on non-Android platforms, with some conditional logic in the test.

Comment 14

[Matt Brubeck (:mbrubeck)]

Pushed test fixes: http://hg.mozilla.org/mobile-browser/rev/c94aa401cc00

Comment 15

[Aaron Train [:aaronmt]]

Unfamiliar with what used to exist. I'm assuming there simply used to exist a close button in the preferences panel for Fennec which is not needed anymore. FFT->Options (Preferences) should suffice?

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13631