600120 - fix canvas composite.uncovered.image tests

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

These were only accidentally passing, because the code that I'm removing in bug 599698 caused us to draw a 0x0 rectangle with whatever the current operator was.  If that was one of the unbounded ones, like these 4, the net result was that the entire canvas was cleared.  Conveniently, "success" in these tests is transparent black.

I suspect that the right thing to do is something similar to what Masatoshi mentions in bug 599698 comment 23:

> Does OperatorAffectsUncoveredAreas function need to be restored?
> (which was removed by bug 366283). See also bug 503283.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

This patch should be applied on top of the patch of bug 599698.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 479042 [details] [diff] [review]
patch

Asking for review on this patch: otherwise, it could easily get forgotten.

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 479042 [details] [diff] [review]
patch

This looks good -- and yes, please do set r? on patches, or they're quite easy to miss :)  Has this gone through the try server?  If so, I'll land both this and the previous patch at the same time.

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to comment #3)
> Has this gone through the try server?  If so, I'll land both this
> and the previous patch at the same time.
Sorry, I have no try server access. I tested it locally on Windows. All canvas mochitest passed.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

So, this failed the Mac machines on tryserver, but I realized that's because roc/jeff fixed these operators on the Quartz surface.  So if I remove the != Quartz surface checks, everything works great.  I'll get this landed along with the previous patch, with that change.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: updated patch without quartz special-casing

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/ea4b83ed71a6