600140 - 'Unread' quick filter hides some unread messages (the beginning of a thread)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Yaniv Kaul]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10 ( .NET CLR 3.5.30729; .NET4.0C)
Build Identifier: 3.1.4

For example, in a patch series, where there's [0/X pathes], followed by a number of patches [1..X], usually patch 0 email is hidden, even though it is unread yet. If I uncheck 'unread', I can see that email, and it is indeed unread. If I again click 'unread', it is now visible correctly - as part of the unread emails.

Reproducible: Always

Actual Results:  
Does not show all unread messages, some are hidden.

Expected Results:  
Should show all unread messages

Been happening ever since the quick filter feature came, so it's not a regression.

Comment 1

[Ludovic Hirlimann [:Usul]]

Does it works better in safe-mdoe (http://support.mozillamessaging.com/en-US/kb/Safe+Mode) ?

Comment 2

[Yaniv Kaul]

(In reply to comment #1)
> Does it works better in safe-mdoe
> (http://support.mozillamessaging.com/en-US/kb/Safe+Mode) ?

No, same phenomena (and the only add-on I have is Lightening)

Comment 3

[Ludovic Hirlimann [:Usul]]

Hum does repairing the folder makes the issue go away ? (right click on the folder -> properties -> repair )

Comment 4

[Wayne Mery (:wsmwk)]

Yaniv,

> Hum does repairing the folder makes the issue go away ? (right click on the
> folder -> properties -> repair )

Comment 5

[[:Aureliano Buendía]]

Yaniv, please, could you answer to comment #3?

Comment 6

[Yaniv Kaul]

(In reply to comment #3)
> Hum does repairing the folder makes the issue go away ? (right click on the
> folder -> properties -> repair )

Never tried that. I usually just disable the filter. I'll try it next time it happens.

Comment 7

[opera wang]

I can confirm this bug, not only 'unread' filter, actually all quick filter may have this issue.

Seems only threaded view (sort by threaded) has this issue. But not all threaded messages will, only a few thread header message will hide.

BTW, 'n messages' shown on the quick filter bar has the right number.

Repair folder doesn't help.

Thunderbird 3.1.9

Comment 8

[opera wang]

Attachment: the emails that has the issue, zipped, password is "thunderbird", no doble quote

unzip the file with password "thunderbird", two files, one mail box, one index.
You should know how to use it :-)

I'd like to remove this attachment once this bug fixed, as the email contains company related information.

Sorry for the inconvenience.

Comment 9

[opera wang]

Attachment: with none-threaded-view, search is OK

Comment 10

[opera wang]

Attachment: with threaded-view, only the second email shown

The test is based on Thunderbird 3.1.9, safe mode.

Comment 11

[opera wang]

This issue only happens when the following code get executed in nsMsgThreadedDBView.cpp:
        if (!(flags & nsMsgMessageFlags::Elided)) // thread is expanded
        {  // insert child into thread
        ...
        }
        else if (aParentKey == nsMsgKey_None)
        {
          // if we have a collapsed thread which just got a new
          // top of thread, change the keys array.
          m_keys[threadIndex] = newKey;
        }

Unlike other execute branch, this branch seems doesn't have code to INSERT one new line.
Don't know if it needed to INSERT one line when the tread is elided.

The file is too complicated for me to fix now ;-)

Comment 12

[Ludovic Hirlimann [:Usul]]

(In reply to comment #11)

> The file is too complicated for me to fix now ;-)

Can we help to make you fix it ?

Comment 13

[opera wang]

OK, please assign it to me.

Can someone tell me how msgKey is calculated?

Comment 14

[Ludovic Hirlimann [:Usul]]

(In reply to comment #13)
> OK, please assign it to me.
> 
> Can someone tell me how msgKey is calculated?

You might want to ask on #maildev on irc.mozilla.org.

Comment 15

[opera wang]

Steps to reproduce:
1. create a (local) mail folder 'foo'
2. select one thread in another folder
3. copy the non-root mail to 'foo'
4. copy the root mail to 'foo' so it has larger msgKey
5. search in mail folder 'foo' with threaded view
6. root mail is missing

Comment 16

[opera wang]

Attachment: use the real thread root

Comment 17

[David :Bienvenu]

thx very much for the patch - I'll try to look at it soon.

Comment 18

[David :Bienvenu]

Comment on attachment 532165 [details] [diff] [review]
use the real thread root

trying this now. For future reference, for importing into mercurial queues, it's easier for us if you do a -p1 diff, because that's what mercurial assumes...

Comment 19

[David :Bienvenu]

Comment on attachment 532165 [details] [diff] [review]
use the real thread root

looks good, thx. One comment, and I can fix this myself when I land this patch, is that it's not so much the message key that's important, it's the fact that the thread root is added after the reply

+  // test bug 600140, make a thread that Reply message has smaller MsgKey

we generally add msgs in msg key order, but that's not always true.

Comment 20

[David :Bienvenu]

I think we might want this for TB 6, since chunked header fetching with newer headers fetched first will make imap users more likely to run into this issue.

Comment 21

[opera wang]

TB5 is out, can we have it in TB6?

Comment 22

[David :Bienvenu]

fixed on trunk - http://hg.mozilla.org/comm-central/rev/53f62c5da9e2

Opera, if you don't have hg commit privileges, you should set check-needed keyword on bug once patch has been review+'d. Apologies on my part for forgetting to communicate this earlier.

Comment 23

[David :Bienvenu]

Comment on attachment 532165 [details] [diff] [review]
use the real thread root

checkin-needed, I should have said. I've requested comm-aurora approval for this patch, which would be required for it to make 6.0...

Comment 24

[Mark Banner (:standard8)]

Checked into aurora:

http://hg.mozilla.org/releases/comm-aurora/rev/f1d1a1749b12