Closed Bug 600215 Opened 9 years ago Closed 9 years ago

Update Initial Developer list in about:license

Categories

(Firefox :: General, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- final+

People

(Reporter: gerv, Assigned: gerv)

Details

(Whiteboard: [hardblocker][happens at RC])

Attachments

(2 files)

(This bug is in the Firefox product so it has the appropriate flags.)

about:license contains an automatically-generated list of every person or entity who is listed in our code files as an Initial Developer (i.e. they created a file), to keep us in compliance with MPL 1.1 section 3.3, sentence 2:
http://www.mozilla.org/MPL/MPL-1.1.html#section-3.3

This list needs regenerating from the current source code before Firefox 4 ships.

Gerv
Assignee: nobody → gerv
blocking2.0: --- → ?
blocking2.0: ? → final+
johnath: I want to fix this bug after all major code changes have landed, but not at the very last minute such that it causes release-driver stress. Can you give me some timing guidance, either in absolute (e.g. 23rd November) or relative (e.g. 5 days after the release of RC1) terms?

Gerv
5 days after RC1 would be too late, since RC1 should be the code we intend to ship, barring last minute discoveries. And a date guideline is a trick - there's a lot of blockers and they'll move as they move, but I understand you wanting to get this squared away.

Honestly, I'd say you probably want to aim to do this around end of October/mid-November and if code lands after that which introduces a new Initial Developer, we'll need a follow up for it.
(In reply to comment #2)
> 5 days after RC1 would be too late,

Sure ;-) It was an example. 

I'll put a note in my diary for the end of October. It only takes 10 minutes to fix with the tools I've got.

Gerv
Whiteboard: [hardblocker]
Whiteboard: [hardblocker] → [hardblocker][happens at RC]
Attached patch Patch v.1Splinter Review
This list was generated today from mozilla-central and comm-central.

To be clear to anyone reading this bug: this list is not a list of credits, it is a technical license-compliance issue. There are no kudos attached to being on the list or off it. It is generated by a machine reading license headers. 

This may be the last time we need to do this, as the advent of MPL 2 (if the Mozilla project chooses to move our codebase to it) will make this list unnecessary, as the relevant license provision has been removed as it is a pain in the behind.

Gerv
Attachment #504669 - Flags: approval2.0?
Comment on attachment 504669 [details] [diff] [review]
Patch v.1

No need to request explicit approval, this is a triaged hardblocker - it gets to land ahead of everything else.
Attachment #504669 - Flags: approval2.0?
changeset:   61378:1365c44328dc
user:        Gervase Markham <gerv@gerv.net>
date:        Thu Jan 27 14:45:58 2011 +0000
summary:     Bug 600215 - update MPL Initial Developers list.

Gerv
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> Created attachment 504669 [details] [diff] [review]
> Patch v.1
> 
> This list was generated today from mozilla-central and comm-central.

Which means you removed the Camino initial developers (again!), which you had me re-add on m-c in bug 553138 comment 4. :P

Also, I suspect any Mobile products from mozilla-central/Gecko 2.0 are going to be out of compliance if the list "continues" to be generated only from mozilla-central and comm-central rather than from all mozilla.org app/product repositories ;-)
(In reply to comment #7)
> Also, I suspect any Mobile products from mozilla-central/Gecko 2.0 are going to
s/from/using/
Smokey: sorry! 

(But if your fix patch had also updated the text at the top with a new date and tree name, it might have given me the hint... :-)

Remind me which tree I also need to scan? Presumably "camino"?

Gerv
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #9)
> Smokey: sorry! 
> 
> (But if your fix patch had also updated the text at the top with a new date and
> tree name, it might have given me the hint... :-)

I have no idea how I missed that. :(

> Remind me which tree I also need to scan? Presumably "camino"?

Yes (and for Fennec/mobile products I believe it's "mobile-browser", though it's probably best to double-check with an actual Fennec dev).
Attached patch Patch v.1bSplinter Review
Here's an additional patch, restoring the names of the Camino developers, and updating the comment. My apologies.

Gerv
http://hg.mozilla.org/mozilla-central/rev/c0c64f24c8a7

Gerv
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.