Closed Bug 600241 Opened 9 years ago Closed 8 years ago

Major part of Minefield's files has a modification date set to 2010-01-01

Categories

(Firefox Build System :: General, defect)

x86_64
All
defect
Not set

Tracking

(blocking2.0 -)

RESOLVED FIXED
Tracking Status
blocking2.0 --- -

People

(Reporter: scoobidiver, Assigned: mwu)

References

Details

(Keywords: regression)

Attachments

(1 file, 3 obsolete files)

Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100928 Firefox/4.0b7pre

Even with a recent creation date, the modification date of the major part of installed files is 2010/01/01 except 2 that have the modification date of the build:
chrome.manifest
omni.jar
Whiteboard: DUPEME
Not caused by the installer...  this was caused by bug 592369. Moving to the component that causes this
Blocks: 592369
Component: Installer → Build Config
Product: Firefox → Core
QA Contact: installer → build-config
mwu, we should only be setting the mod-date for files *in* the omnijar, right?
Assignee: nobody → mwu
blocking2.0: ? → -
We probably could. Does something depend on this behavior?
A bit busy right now - not planning to work on this bug soon unless this causes problems beyond incorrect modified times.
Assignee: mwu → nobody
It is not yet fixed.
Not fixed in 4.0 RC1.
Attached patch Use zip stripping script (obsolete) — Splinter Review
Assignee: nobody → mwu
Attachment #525224 - Flags: review?(tglek)
Attachment #525224 - Flags: review?(khuey)
Comment on attachment 525224 [details] [diff] [review]
Use zip stripping script

Hm actually I think ted wants this more.
Attachment #525224 - Flags: review?(khuey) → review?(ted.mielczarek)
Attachment #525224 - Flags: review?(tglek) → review-
Attached patch Strip zips during optimization (obsolete) — Splinter Review
Attachment #525224 - Attachment is obsolete: true
Attachment #525249 - Flags: review?(tglek)
Attachment #525224 - Flags: review?(ted.mielczarek)
Let's remove directory entries while we're at it.
Attachment #525249 - Attachment is obsolete: true
Attachment #525261 - Flags: review?(tglek)
Attachment #525249 - Flags: review?(tglek)
Need to also decrement dirend.cdir_entries when skipping directories.
Attachment #525261 - Attachment is obsolete: true
Attachment #529752 - Flags: review?(tglek)
Attachment #525261 - Flags: review?(tglek)
Whiteboard: DUPEME
Comment on attachment 529752 [details] [diff] [review]
Strip zips during optimization, v3

This file really needs more comments on what it does.
Attachment #529752 - Flags: review?(tglek) → review+
Two comments added.

http://hg.mozilla.org/mozilla-central/rev/1106d349833d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 684957
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.