Major part of Minefield's files has a modification date set to 2010-01-01

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Scoobidiver (away), Assigned: mwu)

Tracking

({regression})

Trunk
x86_64
All
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

7 years ago
Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20100928 Firefox/4.0b7pre

Even with a recent creation date, the modification date of the major part of installed files is 2010/01/01 except 2 that have the modification date of the build:
chrome.manifest
omni.jar

Updated

7 years ago
Whiteboard: DUPEME
Not caused by the installer...  this was caused by bug 592369. Moving to the component that causes this
Blocks: 592369
Component: Installer → Build Config
Product: Firefox → Core
QA Contact: installer → build-config
blocking2.0: --- → ?
mwu, we should only be setting the mod-date for files *in* the omnijar, right?
Assignee: nobody → mwu
blocking2.0: ? → -
(Assignee)

Comment 3

7 years ago
We probably could. Does something depend on this behavior?
(Assignee)

Comment 4

7 years ago
A bit busy right now - not planning to work on this bug soon unless this causes problems beyond incorrect modified times.
Assignee: mwu → nobody
OS: Windows 7 → All
(Reporter)

Comment 5

7 years ago
It is not yet fixed.
(Reporter)

Comment 6

7 years ago
Not fixed in 4.0 RC1.
(Assignee)

Comment 7

6 years ago
Created attachment 525224 [details] [diff] [review]
Use zip stripping script
Assignee: nobody → mwu
Attachment #525224 - Flags: review?(tglek)
Attachment #525224 - Flags: review?(khuey)
(Assignee)

Comment 8

6 years ago
Comment on attachment 525224 [details] [diff] [review]
Use zip stripping script

Hm actually I think ted wants this more.
Attachment #525224 - Flags: review?(khuey) → review?(ted.mielczarek)

Updated

6 years ago
Attachment #525224 - Flags: review?(tglek) → review-
(Assignee)

Comment 9

6 years ago
Created attachment 525249 [details] [diff] [review]
Strip zips during optimization
Attachment #525224 - Attachment is obsolete: true
Attachment #525249 - Flags: review?(tglek)
Attachment #525224 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 10

6 years ago
Created attachment 525261 [details] [diff] [review]
Strip zips during optimization, v2

Let's remove directory entries while we're at it.
Attachment #525249 - Attachment is obsolete: true
Attachment #525261 - Flags: review?(tglek)
Attachment #525249 - Flags: review?(tglek)
(Assignee)

Comment 11

6 years ago
Created attachment 529752 [details] [diff] [review]
Strip zips during optimization, v3

Need to also decrement dirend.cdir_entries when skipping directories.
Attachment #525261 - Attachment is obsolete: true
Attachment #529752 - Flags: review?(tglek)
Attachment #525261 - Flags: review?(tglek)
(Assignee)

Updated

6 years ago
Whiteboard: DUPEME

Comment 12

6 years ago
Comment on attachment 529752 [details] [diff] [review]
Strip zips during optimization, v3

This file really needs more comments on what it does.
Attachment #529752 - Flags: review?(tglek) → review+
(Assignee)

Comment 13

6 years ago
Two comments added.

http://hg.mozilla.org/mozilla-central/rev/1106d349833d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 684957
You need to log in before you can comment on or make changes to this bug.