600367 - Add multi-app and release type support to Discovery pane promos

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P2)

Description

[Justin Scott [:fligtar]]

The management tool and front-end should support application-specific criteria and release type in addition to the existing locale support.

For applications, this can be a single app for simplification. (i.e., this module only shows up for Firefox)

For version type, there are 3 choices: stable, development, and all. If the user's version is any stable release (no letters in it) it is stable. Any alphas, betas, nightlies should be classified as development.

A sample of the populated modules (in CSV form) might be:
1,Firefox Tester Tools,all,firefox,development
2,Rock Your Firefox,en-US,firefox,all
3,Shopping,all,firefox,stable
4,Thunderbird Rocks,all,thunderbird,all

Comment 1

[Wil Clouser [:clouserw]]

We'll try to get this in q1

Comment 2

[Andrei Hajdukewycz [:sancus]]

per irc, I'm taking this and I'll r? cvan.

Comment 4

[Wil Clouser [:clouserw]]

What's the status of this?

Comment 5

[Andrei Hajdukewycz [:sancus]]

Sorry for the delay, I ran into some roadblocks due to no good test database(basically for this to work properly I need a database with a collection in it) and I've been pretty overwhelmed with other work also. I am going to try to get this done this week.

Comment 6

[Wil Clouser [:clouserw]]

The celery backend for LAMO isn't finished yet, but I think you can make a few collections with no problems.  I haven't advertised the site yet (still working some kinks out) but if you want to be an alpha tester:

https://landfill.addons.allizom.org/
https://landfill.addons.allizom.org/db/

Comment 7

[Andrei Hajdukewycz [:sancus]]

I live for alpha testing things, I'll try it out and let you know if I run into any problems!

Comment 8

[Wil Clouser [:clouserw]]

How's this going?

Comment 9

[Wil Clouser [:clouserw]]

What's going on here?

Comment 10

[Andrei Hajdukewycz [:sancus]]

I didn't really have time to properly deal with this bug in the flurry of 100-hour weeks leading up to Thunderbird launch, but now I will. From what I've figured out so far, the way this bug was originally stated is incorrect. Multi-App support ALREADY exists, and applications are easily managed via django admin page for this table.

Right now the real problems we want to solve are:
1) Collections need to be defined in Python currently, with a specific id for the collection. This should be moved into the database so that you can add collections via the site admin page and not require a patch.
2) The above means the discovery pane needs to be changed to pull completely from the database.
3) Release type support needs to be added.

So, I'm working on the above now. I have some time with the TB move to mozilla.org/thunderbird completed.

Comment 11

[Wil Clouser [:clouserw]]

(In reply to comment #10)
> I didn't really have time to properly deal with this bug in the flurry of
> 100-hour weeks leading up to Thunderbird launch, but now I will. From what
> I've figured out so far, the way this bug was originally stated is
> incorrect. Multi-App support ALREADY exists, and applications are easily
> managed via django admin page for this table.
> 
> Right now the real problems we want to solve are:
> 1) Collections need to be defined in Python currently, with a specific id
> for the collection. This should be moved into the database so that you can
> add collections via the site admin page and not require a patch.
> 2) The above means the discovery pane needs to be changed to pull completely
> from the database.
> 3) Release type support needs to be added.
> 
> So, I'm working on the above now. I have some time with the TB move to
> mozilla.org/thunderbird completed.

I think 1 and 2 are already being worked on or are already done in another branch.  I'm not sure what #3 means.

Comment 12

[Christopher Van Wiemeersch [:cvan]]

Do we still want this? Given D2C and all?

Comment 13

[Andrei Hajdukewycz [:sancus]]

Half of this bug was already completed as the result of other bugs being fixed, I think the only thing that this bug might refer to is having different promos per channel? Like different ones for aurora, beta, release.

If that's not needed/wanted then this bug is already fixed I think.

Comment 14

[Andrei Hajdukewycz [:sancus]]

I'm pretty sure the original goals of this bug were solved long ago, reopen if you disagree :)