600646 - Speed up the new tab animation

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Aza Raskin [:aza]]

Creating a new tab using the new tab button feels unacceptably slow. We need to chop it down or remove it.

Comment 1

[Aza Raskin [:aza]]

Attachment: Patch v1

This drastically speeds up the new tab animation. Much nicer now.

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 479567 [details] [diff] [review]
Patch v1

I love it. 

+    //iQ(newItem.container).css({backgroundColor: "white"});

Remove this commented out code. 

f+ with that

Comment 3

[Aza Raskin [:aza]]

Attachment: Patch v2

Got feedback+ from Ian!

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 479668 [details] [diff] [review]
Patch v2

>+++ b/browser/themes/gnomestripe/browser/tabview/tabview.css
> .thumb {
>   box-shadow: 1px 2px 0 rgba(0, 0, 0, 0.2);
>+  background-color: white;  
> }

Why the CSS changes? Doesn't seem related -- meant for some other bug?

Comment 5

[Aza Raskin [:aza]]

I probably should have put this as a comment, but the backgrounds of tabs were clear which meant that if there wasn't a thumbnail (like the first time you made a new tab) all you would get was a bounding box and a clear center. Adding a white background means that a blank tab always is filled in.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

We won't take this for b7, but will for b8.

Comment 7

[Ian Gilman [:iangilman]]

Comment on attachment 479668 [details] [diff] [review]
Patch v2

Now that it's blocking, it doesn't need approval. 

Aza, can you please update the patch for landing and I'll push it to panorama-central?

Comment 8

[Aza Raskin [:aza]]

About to take for Berlin; Ian would you mind updating the patch?

Comment 9

[Ian Gilman [:iangilman]]

Pushed to panorama-central:

http://hg.mozilla.org/users/ian_iangilman.com/panorama-central/rev/a44cbf58508b

Comment 10

[Ian Gilman [:iangilman]]

Landed on mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/a44cbf58508b

Comment 11

[u88484]

Now there is just a delay then the tab appears with no animation.  The delay makes opening a new tab take longer to open then with firefox 3.6.

Comment 12

[Ian Gilman [:iangilman]]

(In reply to comment #11)
> Now there is just a delay then the tab appears with no animation.  The delay
> makes opening a new tab take longer to open then with firefox 3.6.

I'm not seeing that on the latest mozilla-central... I get a fast animation right away. 

Are you clicking the "new tab" button in the lower left of the group, or are you hitting the "new tab" command key?

Comment 13

[u88484]

(In reply to comment #12)
> (In reply to comment #11)
> > Now there is just a delay then the tab appears with no animation.  The delay
> > makes opening a new tab take longer to open then with firefox 3.6.
> 
> I'm not seeing that on the latest mozilla-central... I get a fast animation
> right away. 
> 
> Are you clicking the "new tab" button in the lower left of the group, or are
> you hitting the "new tab" command key?

Sorry, I must have not restarted to apply the update that this changeset was in.  For the record I was using ctrl+t

Comment 14

[Ian Gilman [:iangilman]]

(In reply to comment #13)
> Sorry, I must have not restarted to apply the update that this changeset was
> in.  For the record I was using ctrl+t

There's no animation for the key combo (just the button), but it should be plenty fast.

Comment 15

[Tracy Walker [:tracy]]

verified in recent nightly build of minefield