please remove/disable support for PUT/DELETE in HTML forms

RESOLVED FIXED

Status

()

Core
HTML: Form Submission
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Julian Reschke, Assigned: mounir)

Tracking

({dev-doc-complete})

Trunk
dev-doc-complete
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.10) Gecko/20100914 Firefox/3.6.10 (.NET CLR 3.5.30729)
Build Identifier: 

This was removed from HTML5 because it was underspecified, see 

  http://www.w3.org/Bugs/Public/show_bug.cgi?id=10671

and 

  http://html5.org/tools/web-apps-tracker?from=5565&to=5566

I think this needs to happen before Firefox 4.0, because shipping the current implementation may make it harder to introduce this later on when a better specification is done.

Reproducible: Always
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?
Haven't we had this support for a while now?  Or is this a new feature in the 2.0 cycle?
(Reporter)

Comment 2

7 years ago
According to

  https://bugzilla.mozilla.org/show_activity.cgi?id=583288

it was added this month.
Ah, perfect.  Thanks.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Component: DOM: Core & HTML → HTML: Form Submission
OS: Windows 7 → All
QA Contact: general → form-submission
Hardware: x86 → All
(Assignee)

Comment 4

7 years ago
Disabling them would be easy or do we want to backout everything from bug 583288?
(Assignee)

Updated

7 years ago
Version: unspecified → Trunk
(Assignee)

Comment 5

7 years ago
I don't think this is "major". However, considering this is a new feature we are going to remove, should we fix that for beta7?
Severity: major → normal
blocking2.0: ? → beta7+
(Assignee)

Updated

7 years ago
Assignee: nobody → mounir.lamouri
(Assignee)

Comment 6

7 years ago
I'm going to backout that.
Status: NEW → ASSIGNED
(Assignee)

Comment 7

7 years ago
Backout logs:
http://hg.mozilla.org/mozilla-central/rev/decd45d66d66
http://hg.mozilla.org/mozilla-central/rev/b57b428e8e71
http://hg.mozilla.org/mozilla-central/rev/198346fcc178
http://hg.mozilla.org/mozilla-central/rev/4ace6b349a3c
http://hg.mozilla.org/mozilla-central/rev/b343269c3aa4
http://hg.mozilla.org/mozilla-central/rev/669eb2d837d7

This was hard :-/
I will fix this bug if the tree is still green...
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
I've removed the relevant doc from the MDN (see bug 583288 for details).
Keywords: dev-doc-needed
    11.1 --- a/content/html/content/test/test_bug585508.html
    11.2 +++ b/content/html/content/test/test_bug585508.html
    11.3 @@ -30,9 +30,11 @@ var methodTestData = [
    11.4    // Default value.
    11.5    [ "get" ],
    11.6    // Valid values.
    11.7 -  [ "get", "post", "put", "delete" ],
    11.8 +  [ "get", "post" ],
    11.9    // Invalid values.
   11.10    [ "", " ", "foo" ],
   11.11 +  // TODO values, see bug 583289 and bug 583288.
   11.12 +  [ "delete", "put" ],
   11.13  ];
   11.14  
   11.15  function checkAttribute(form, attrName, idlName, data)

Could you fix that too?
(Assignee)

Comment 10

7 years ago
Created attachment 480179 [details] [diff] [review]
Patch cleaning test

With sicking's r+.
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 11

7 years ago
Test update pushed:
http://hg.mozilla.org/mozilla-central/rev/b4db96c6b608
You need to log in before you can comment on or make changes to this bug.