600861 - Disable accelerated layers for profile manager

Status: NEW

(Core :: Graphics, defect)

Description

[Rob Campbell [:rc] (:robcee)]

I'm seeing some pretty bad rendering on the Profile Manager at startup on my system.

See: http://people.mozilla.org/~rcampbell/images/layers/Screen%20shot%202010-09-30%20at%2011.38.42.png

for an example.

System Profiler hardware report:
Model Name:	Mac Pro
  Model Identifier:	MacPro1,1
  Processor Name:	Dual-Core Intel Xeon
  Processor Speed:	2.66 GHz
  Number Of Processors:	2
  Total Number Of Cores:	4
  L2 Cache (per processor):	4 MB
  Memory:	12 GB
  Bus Speed:	1.33 GHz
  Boot ROM Version:	MP11.005C.B08

ATI Radeon X1900 XT:

  Chipset Model:	ATY,RadeonX1900
  Type:	GPU
  Bus:	PCIe
  Slot:	Slot-1
  PCIe Lane Width:	x16
  VRAM (Total):	512 MB
  Vendor:	ATI (0x1002)
  Device ID:	0x7249
  Revision ID:	0x0000
  ROM Revision:	113-A52027-140
  EFI Driver Version:	01.00.140
  Displays:
Display:
  Resolution:	2560 x 1600 @ 60 Hz
  Pixel Depth:	32-Bit Color (ARGB8888)
  Main Display:	Yes
  Mirror:	Off
  Online:	Yes
  Rotation:	Supported
Display Connector:
  Status:	No Display Connected

Comment 1

[Joe Drew (not getting mail)]

This specific bug is fixed, but we should still disable hardware acceleration for the profile manager, if for no other reason than HW accel's status is determined by the profile, and we shouldn't use it if we don't know that we definitely should.

Comment 2

[(no longer active)]

Attachment: WIP

I took a stab at this.  Turns out that the accelerated attribute does not match how it's documented (we check for its existence and not its value).  I fixed that.  Also the mUseAcceleratedRendering flag gets set on an nsCocoaWindow, but nsBaseWidget::GetLayerManager gets called on an nsChildView, which means that the flag set by nsXULWindow::SyncAttributesToWidget is not seen at all.

I gave up fixing the latter problem.  Someone else can pick this up, I guess.

Comment 3

[(no longer active)]

Moving to Graphics since it is the accelerated attribute which doesn't work correctly.