Closed
Bug 600874
Opened 14 years ago
Closed 14 years ago
Show restart notification for add-on updates
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(fennec2.0b3+)
VERIFIED
WORKSFORME
Tracking | Status | |
---|---|---|
fennec | 2.0b3+ | --- |
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(2 files)
1.53 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
19.75 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
When add-on updates are found, we add a label to the add-on item, but don't show a restart notification. If the updated add-on requires a restart, we should.
Not sure if we also want to show a system notification when this happens?
Relevant code:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/extensions.js#673
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → wjohnston
Comment 1•14 years ago
|
||
Without the restart notification, there is no way to actually activate the new version of an addon that had been disabled for compatibility.
tracking-fennec: --- → ?
Comment 2•14 years ago
|
||
We should be showing a restart notification if the extension was marked as "updateable":
http://mxr.mozilla.org/mobile-browser/source/chrome/content/extensions.js#709
That allows us to customize the restart message:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/extensions.js#797
but since we actually check before we set the _updating flag, it's worthless:
http://mxr.mozilla.org/mobile-browser/source/chrome/content/extensions.js#776
Looks like we need to re-arrange the code a bit there (and figure out why it was moved in the first place - I don't want to regress something else)
Updated•14 years ago
|
tracking-fennec: ? → 2.0b2+
Assignee | ||
Comment 3•14 years ago
|
||
I think this is fallout from Bug 562495. It looks like XPInstallDownloadManager had onInstallEnded and onInstallsCompleted methods that we collapsed into one single onInstallEnded method.
Comment 4•14 years ago
|
||
(In reply to comment #3)
> I think this is fallout from Bug 562495. It looks like XPInstallDownloadManager
> had onInstallEnded and onInstallsCompleted methods that we collapsed into one
> single onInstallEnded method.
OK, but fallout how?
Updated•14 years ago
|
tracking-fennec: 2.0b2+ → 2.0b3+
Assignee | ||
Comment 5•14 years ago
|
||
Not quite sure what you mean finkle, but this should fix this. Its really hard to test though, so I'm going to try and get some browser chrome tests to make sure.
Comment 6•14 years ago
|
||
Comment on attachment 483209 [details] [diff] [review]
Simple fix
This will fix the type of message shown in the restart, but you did nothing extra to show the restart itself. Unless the fact we were accessing | this._updating |, which wasn't set, was throwing an error and exiting the method.
The fix is good in any case.
Attachment #483209 -
Flags: review+
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•14 years ago
|
||
Whoops. This regressed (Bug 605102) because I forgot to move up the:
element = ...
part. I have 90% of some tests written for this anyway, and hopefully I can get a better fix in today.
Updated•14 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•14 years ago
|
||
It seems like things are mostly working fine. If you update an extension or install an extension (non-bootstraped) we show a restart notification. Bootstrapped extensions don't provide much feedback that they've installed correctly, but that needs a different bug. The text in the update case was not updated to say anything about the upgrade, so I fixed that here, and added a few tests.
Attachment #484108 -
Flags: review?(mark.finkle)
Comment 10•14 years ago
|
||
Comment on attachment 484108 [details] [diff] [review]
Fix + Tests
File a bug on the bootstrap add-on installation message?
Attachment #484108 -
Flags: review?(mark.finkle) → review+
Comment 11•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
Flags: in-testsuite+
Restart for addons are still not showing for Android/Maemo:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre Fennec/4.0b2pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101019 Firefox/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 13•14 years ago
|
||
Wes - Thoughts? Are the tests passing?
Note: the addon was installed using a install trigger.
( bug 605801 )
Assignee | ||
Comment 15•14 years ago
|
||
Naoki, I've been playing with this a lot lately and haven't been able to reproduce with my addons. Can you give me some more specific steps?
WFM:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → WORKSFORME
Comment 17•14 years ago
|
||
WFM as well on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101105 Namoroka/4.0b8pre Fennec/4.0b2pre
and
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101105 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•