605801 - No restart notification when installing add-ons from AMO

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Device: Motorola Droid 2
BuildID: Mozilla /5.0 (Maemo;Linux armv7l;rv:2.0b8pre)Gecko/20101020
Firefox/4.0b8pre Fennec /4.0b2pre 

Steps to reproduce:

1. Open Fennec
2. Go to AMO 
3. Install a recommended add-on (TwitterBar for example).

Expected results:
- A restart notification is displayed after the add-on is installed -> either present in the status bar of the device or a pop up in the right corner

Actual results:
- No notification is displayed.

Comment 1

[Aakash Desai [:aakashd]]

Yep, I can confirm this on builds:

Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101020 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101020 Namoroka/4.0b8pre Fennec/4.0b2pre

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Fixes

This should fix this. In my last fixes I moved the place where we were bailing out if no element existed for the addon. That was true any time we hadn't called _delayedInit here (i.e. if you hadn't looked at the Add-ons manager yet).

Here I'm not bailing out at all, but just moved all of the stuff requiring an element into its own block.

Tested this by modifying a nightly. Still building my daily build to test. Also started writing a test for this.

Comment 3

[Wesley Johnston (:wesj)]

With this patch, tested and work:

1.) Visit AMO directly through urlbar, install addon
2.) Visit AMO through add-on manager page, install addon
3.) Install addon through add-on manager

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

dup of bug 600874?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 484717 [details] [diff] [review]
Fixes


>   onInstallEnded: function(aInstall, aAddon) {
>     let element = ExtensionsView.getElementForAddon(aAddon.id);
>-    if (!element)
>-      return;
>+    this._updating = element && element.hasAttribute("updating");
>+    if (aAddon.pendingOperations & AddonManager.PENDING_INSTALL)
>+      ExtensionsView.showRestart(this._updating ? "update" : "normal");

Can we move the this._updating down into the | if (element) { | bock and use:

aAddon.pendingOperations & AddonManager.PENDING_UPGRADE

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/AddonManager.jsm#989

r+ but I'd like to smooth this out a little

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Fix v2

Fixes after talking to Mossop about this. I've also got a few addons setup for testing this and addon upgrades/uninstalls:

https://dl.dropbox.com/u/72157/Testing/extensions/testInstallAndUpgrade.html

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Fix v3.

Missed a call to of this._updating

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/1a81b76129f6

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101021 Namoroka/4.0b8pre Fennec/4.0b2pre
    
but follow-up filed in bug 606178. This is not happening on the n900 nightly.