601145 - Mac64 builds from today won't start when using profile manager

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[u279076]

Today's mozilla-central nightlies (2010-10-01) will not start using the profile manager.

1. firefox-bin -P -no-remote
2. select a profile or create a new one
3. Start
4. select a profile or create a new one
5. Start
6. repeat...repeat...repeat...

Result:
Firefox is stuck in a loop at the Profile Manager

Expected:
Firefox starts with the profile, or at least give me an error.

Comment 1

[u279076]

Yesterday's build is fine:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20100930 Firefox/4.0b7pre

Comment 2

[u279076]

Apparently, the source stamp is:
http://hg.mozilla.org/mozilla-central/rev/a60414d076b5

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

> Apparently, the source stamp is:
> http://hg.mozilla.org/mozilla-central/rev/a60414d076b5

That's surprising, as that's Wed, Sep 29 and someone said the builds from the 30th are fine.

I suspect bug 600411.

Comment 4

[Marcia Knous [:marcia]]

I am not sure if since Bug 600411 was fixed whether or not a new 10.5 build is supposed to launch as well, but the same thing happens using a 10.5 build when I download the latest nightly. There are a number of errors in the console that I can paste if it is helpful.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Please paste!

Comment 6

[Josh Aas]

I can confirm that bug 600411 caused this. Backing it out fixes the problem.

Comment 7

[(not currently active) Ted Mielczarek]

I just hit what is probably the same problem while working on the crashreporter patch. The problem is that you're passing NULL as the last param of posix_spawnp, so the child process gets an empty set of environment variables. You can pass *_NSGetEnviron() (after #include <crt_externs.h>) to copy the current process' environment.

Comment 8

[(not currently active) Ted Mielczarek]

(also the restart process uses environment variables to pass state, which is why this is happening.)

Comment 9

[Marcia Knous [:marcia]]

Attachment: Output from Mac console on 10.5

May not be useful, but adding in case it is.

Comment 10

[Josh Aas]

Attachment: fix v1.0

Comment 11

[Josh Aas]

I wonder if we want to propagate environment variables to things launched by nsIProcess. My patch for bug 600711 does not propagate them.

Comment 12

[Josh Aas]

Attachment: fix v1.1

This is a little safer, checks pointer from _NSGetEnviron before derefing it.

Comment 13

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/f14d1020c04c

Comment 14

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> I am not sure if since Bug 600411 was fixed whether or not a new 10.5 build is
> supposed to launch as well

Bug 600411 only fixed one of the cases where a 10.5 build would crash (restart triggered from the app). 10.5 builds still crash before and after the update is applied (bug 600777, bug 600362).

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7pre) Gecko/20101002 Firefox/4.0b7pre