Closed Bug 600411 Opened 14 years ago Closed 14 years ago

fix app-initiated restart (LaunchChildMac) to launch the right architecture on OS X 10.5

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking2.0 --- beta7+

People

(Reporter: ted, Assigned: jaas)

References

Details

Attachments

(1 file, 3 obsolete files)

fix v1.3
3.67 KB, patch
Details | Diff | Splinter Review
MacLaunchChild: http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/MacLaunchHelper.mm#51 is used in app-initiated restart (like restarting from the extension manager) to relaunch the current process. Similarly to bug 600362, it will need to be fixed to launch the correct architecture binary on OS X 10.5.
Same question as in bug 600408 - seems to me like this needs to block b7, assuming this config is what we're going to ship...
blocking2.0: --- → beta7+
This is the config we're shipping, AFAIK, and if we don't fix this, using app-initiated restart will crash on restart on 10.5. Manually launching the app again will work, though.
Attached patch fix v1.0 (obsolete) — — Splinter Review
My work so far. I haven't tested this. The approach is to prefer to launch the child as whatever the current process is.
Assignee: nobody → joshmoz
Attached patch fix v1.1 (obsolete) — — Splinter Review
Fix memory leak.
Attachment #479390 - Attachment is obsolete: true
Attachment #479588 - Flags: review?(benjamin)
Does this cover the case where we start Firefox from off, find an update pending, and launch the updater ? That's broken on 10.5 too.
I don't think so - that looks to be handled by nsUpdateDriver.cpp. I guess I'll file another bug...
Attached patch fix v1.2 (obsolete) — — Splinter Review
Attachment #479588 - Attachment is obsolete: true
Attachment #479896 - Flags: review?(benjamin)
Attachment #479588 - Flags: review?(benjamin)
Comment on attachment 479896 [details] [diff] [review] fix v1.2 This looks right to me, but rs should confirm.
Attachment #479896 - Flags: review?(robert.bugzilla)
Attachment #479896 - Flags: review?(benjamin)
Attachment #479896 - Flags: review+
Comment on attachment 479896 [details] [diff] [review] fix v1.2 looks fine to me as well
Attachment #479896 - Flags: review?(robert.bugzilla) → review+
Attached patch fix v1.3 — — Splinter Review
Use anonymous namespace to avoid symbol for static CPU preference array conflicting with other symbols in the library.
Attachment #479896 - Attachment is obsolete: true
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/e000a23be43f
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
This looks like it may have resulted in bug 601145
Depends on: 601145
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: