601260 - Cache all messages in the ConsoleStorageService once all web console observers are running

Status: RESOLVED DUPLICATE of bug 611032

(DevTools :: General, defect, P1)

Description

[David Dahl :ddahl]

There is a new cache/storage service landing with bug 568629. we should send all messages that emanate from the httpActivityObserver, nsIConsoleService Observer to the new storage service so that when a console is opened we can view any errors that happened previous to opening the web console.

Comment 1

[David Dahl :ddahl]

Actually, by default, we should only cache console API messages as well as errors and css parsing errors. Perhaps with a pref we can also listen for http activity.

This bug is basically breaking out our nsIConsoleService observer into a small service (in a JSM loaded at final-ui-startup) that knows how to record all error messages per window into the ConsoleStorageService.

This will then allow users to open the console and see all of the errors that have already happened.

Comment 2

[Kevin Dangoor]

Holding on to script and CSS errors that come through while the console is closed at least is a blocker, given the expectations that people have established with the Error Console.

Comment 3

[Nochum Sossonko [:Natch]]

What about memory/perf concerns? Is it being limited to 250? Or is is not a factor anymore?

Comment 4

[Kevin Dangoor]

I believe the service hangs on to 200 events and does not (or will not -- there may be a patch outstanding there) keep request/response bodies unless told to do so.

Comment 5

[Rob Campbell [:rc] (:robcee)]

marking as assigned.

Comment 6

[Rob Campbell [:rc] (:robcee)]

we won't be keeping request/response bodies by default, no.

200 events may be small for a service like this. We'll have to experiment a little.

Comment 8

[David Dahl :ddahl]

(In reply to comment #6)
> we won't be keeping request/response bodies by default, no.
> 
> 200 events may be small for a service like this. We'll have to experiment a
> little.

it is 200 events per tab. the existing error console is 300 total per browser. Perhaps we should make this configurable?

Comment 9

[Rob Campbell [:rc] (:robcee)]

since beta8 is tomorrow and the lazy console which this depends on hasn't landed yet, I'm hoping we can push this to next beta.

Comment 10

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 11

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 12

[Rob Campbell [:rc] (:robcee)]

assigning this to david. This should probably now be a dupe of bug 612658 since there is no work here.

Comment 13

[Kevin Dangoor]

mass change: filter mail on BLOCKERSETTING

Comment 14

[David Dahl :ddahl]

(In reply to comment #12)
> assigning this to david. This should probably now be a dupe of bug 612658 since
> there is no work here.

actually this is a dupe of bug 611032