602199 - Eliminate cached console data when moving in and out of Private Browsing

Status: RESOLVED DUPLICATE of bug 612658

(DevTools :: General, defect, P1)

Description

[Kevin Dangoor]

Comments from dveditz during the security review of the Web Console:

currently not caching data, but when we are it should be purged when going into/out of Private Browsing mode.

There may not be an issue in practice, but we definitely need to see what the behavior is and confirm that it is as expected.

Comment 1

[Nochum Sossonko [:Natch]]

The Error Console (and console service) are cleared on enter/exit private browsing, the same should be done here (aiui the Web Console will be caching its messages).

Comment 2

[Patrick Walton (:pcwalton)]

Now that the lazy console has landed, it makes sense to do this one. Assigning to self just so it's not lost (Mihai, feel free to take if you'd like).

Comment 3

[Kevin Dangoor]

I hadn't worried about assigning this one yet, because there's no cache to clear yet (there are other bugs for that like bug 601260 on which this one depends.)

Comment 4

[David Dahl :ddahl]

This patch will be something like:

XPCOMUtils.defineLazyServiceGetter(this, "gConsoleStorage",
                                   "@mozilla.org/console-storage-service;1",
                                   "nsIConsoleStorageService");

// in an observer for "private browsing exit" (or whatever it is called)

gConsoleStorage.deleteStorage()

Although, now that I look at the IDL, it seems like we need a resetStorage() method that deletes the storage data and re-initializes it with an empty array.

Comment 5

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 6

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 7

[:Gavin Sharp [email: [e-mail]]]

It would probably be best to have the ConsoleStorageService handle this itself...

Comment 8

[David Dahl :ddahl]

(In reply to comment #7)
> It would probably be best to have the ConsoleStorageService handle this
> itself...

as per this comment - talking this bug and the patch with be part of the initial ConsoleStorageService bug 612658 (the test is larger than the changes required)

Comment 9

[David Dahl :ddahl]

Attachment: WIP, failing test

saving work

Comment 10

[David Dahl :ddahl]

Attachment: v 0.1 Tests included

This patch requires the patches from bug 612658 and bug 609890

Comment 11

[David Dahl :ddahl]

This bug should block as it has to do with privacy.