Add xpcshell tests to schema-validation

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: imphil, Assigned: imphil)

Tracking

Trunk
x86_64
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 480348 [details] [diff] [review]
add xpcshell tests

schema-validation currently has some tests, but those need to be run manually. I converted them to xpcshell tests that can be run the usual way from the objdir:

TEST_PATH=_tests/xpcshell/extensions/schema-validation/tests/unit make xpcshell-tests

This also uncovered some leaks, but I'll look into those another time.

The goal behind this is to have automated tests for schema-validation and xforms that can be run every night to discover Gecko changes that affect us faster than it's the case right now and speed up the process of fixing those bugs (while not regressing existing functionality).
(Assignee)

Updated

7 years ago
Depends on: 601300, 601301
(Assignee)

Updated

7 years ago
Assignee: nobody → mail
(Assignee)

Updated

7 years ago
Attachment #480348 - Flags: review?(Olli.Pettay)
(Assignee)

Comment 1

7 years ago
Created attachment 481613 [details] [diff] [review]
patch v1.1: add xpcshell tests

changes in v1.1: take the components out of the build dirs, not out of FINAL_TARGET (it's not there any more with bug 601570). This also removes the need to check for already registered components as they will registered only once.
Attachment #480348 - Attachment is obsolete: true
Attachment #481613 - Flags: review?(Olli.Pettay)
Attachment #480348 - Flags: review?(Olli.Pettay)

Comment 2

7 years ago
Comment on attachment 481613 [details] [diff] [review]
patch v1.1: add xpcshell tests

This is rs.
Attachment #481613 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

7 years ago
Attachment #481613 - Flags: review?(surkov.alexander)

Comment 3

7 years ago
I don't feel myself as a right person to review this. But I think that's ok to land it with Olli's rs only until anybody has objections.
(Assignee)

Comment 4

7 years ago
Doron, Aaron: Does this look ok to you? Essentially this patch only automates the existing tests for schema-validation.
Status: NEW → ASSIGNED

Comment 5

7 years ago
AFAICT it looks good.  But I don't know much about these shell tests.  Can they be run standalone (i.e run easily, outside of a harness)?  If not I'd like the old tests to still remain in the tree.
(Assignee)

Comment 6

7 years ago
You only need to add --enable-tests when building Mozilla/XForms. Then you can use the command in comment 0 to run the tests. Nothing else needs to be set up or configured first.
(Assignee)

Comment 7

7 years ago
If nobody objects I'll commit this tomorrow.

Comment 8

7 years ago
(In reply to comment #7)
> If nobody objects I'll commit this tomorrow.

You could always fix future comments after the checkin. That's not preferable but it works in general.
(Assignee)

Comment 9

7 years ago
http://hg.mozilla.org/schema-validation/rev/cbac741a9553
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Attachment #481613 - Flags: review?(surkov.alexander)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.