Closed Bug 601309 Opened 14 years ago Closed 14 years ago

Add xpcshell tests to schema-validation

Categories

(Core Graveyard :: XForms, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: imphil, Assigned: imphil)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch add xpcshell tests (obsolete) — Splinter Review
schema-validation currently has some tests, but those need to be run manually. I converted them to xpcshell tests that can be run the usual way from the objdir:

TEST_PATH=_tests/xpcshell/extensions/schema-validation/tests/unit make xpcshell-tests

This also uncovered some leaks, but I'll look into those another time.

The goal behind this is to have automated tests for schema-validation and xforms that can be run every night to discover Gecko changes that affect us faster than it's the case right now and speed up the process of fixing those bugs (while not regressing existing functionality).
Depends on: 601300, 601301
Assignee: nobody → mail
Attachment #480348 - Flags: review?(Olli.Pettay)
changes in v1.1: take the components out of the build dirs, not out of FINAL_TARGET (it's not there any more with bug 601570). This also removes the need to check for already registered components as they will registered only once.
Attachment #480348 - Attachment is obsolete: true
Attachment #481613 - Flags: review?(Olli.Pettay)
Attachment #480348 - Flags: review?(Olli.Pettay)
Comment on attachment 481613 [details] [diff] [review]
patch v1.1: add xpcshell tests

This is rs.
Attachment #481613 - Flags: review?(Olli.Pettay) → review+
Attachment #481613 - Flags: review?(surkov.alexander)
I don't feel myself as a right person to review this. But I think that's ok to land it with Olli's rs only until anybody has objections.
Doron, Aaron: Does this look ok to you? Essentially this patch only automates the existing tests for schema-validation.
Status: NEW → ASSIGNED
AFAICT it looks good.  But I don't know much about these shell tests.  Can they be run standalone (i.e run easily, outside of a harness)?  If not I'd like the old tests to still remain in the tree.
You only need to add --enable-tests when building Mozilla/XForms. Then you can use the command in comment 0 to run the tests. Nothing else needs to be set up or configured first.
If nobody objects I'll commit this tomorrow.
(In reply to comment #7)
> If nobody objects I'll commit this tomorrow.

You could always fix future comments after the checkin. That's not preferable but it works in general.
http://hg.mozilla.org/schema-validation/rev/cbac741a9553
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #481613 - Flags: review?(surkov.alexander)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: