60178 - Mozilla shows escaped text in status text field

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Henrik Gemal]

If you have the following HTML tag:
<A href='mailto:"Mogens Kühn Pedersen" <[e-mail]>'>[e-mail]</A>
the status field of the browser says:
mailto:%22Mogens%20K%FChn%20Pedersen%22%20%3Cmk.inf%40cbs.dk%3E

Expected:
The status field should show the correct non escaped link.

Trunk Mozilla Build 2000111420

Comment 1

[sairuh (rarely reading bugmail)]

henrik, could you provide a url that has such a link for us to test? bill, would
you know who'd be the one to fix this?

thx!

Comment 2

[Henrik Gemal]

Attachment: test case with escaped chars in the status text line

Comment 3

[Bill Law]

I'm trying to set the URL link in this bug so that it shows the problem
(although I'm not sure Bugzilla will let me do it)...

Comment 4

[Bill Law]

Hmm, that's interesting; looks like Bugzilla won't let me do that.

Comment 5

[Bill Law]

I'm not sure that's a valid mailto: url (with the name enclosed in "").  I'll
set up a test page on my internal web server and try it out with 4.x and IE.
This bug can stay with xpapps although it might really be do to code inside the
Gecko HTMLLinkElement.

Comment 6

[Henrik Gemal]

Works in Netscape 4.76

Comment 7

[Henrik Gemal]

Invalid mailto: or not. The status text should show the link. Not something 
else, like escaped text....

Comment 8

[Bill Law]

Attachment: sample page with same link but with u-umlaut removed

Comment 9

[Bill Law]

OK, I've attached another sample with the same mailto: link except that I've
replaced the u-umlaut.  That one works fine.  So the problem seems related to
the presence of certain characters in the URL.  I think this is definitely not
our bug.  But I'm not sure if it's an intl thing or in Gecko url-parsing or
elsewhere.

Sarah, how about you decide and reassign (how's that for passing the buck)?

Comment 10

[sairuh (rarely reading bugmail)]

thanks for the testcase, bill!

hmmm...who should get this... i'll try i18n this time. :)

Comment 11

[nhottanscp]

Reassign to yokoyama.

Please look at nsWebShell::OnOverLink,
http://lxr.mozilla.org/seamonkey/search?string=nsWebShell%3A%3AOnOverLink
and get a document charset then use nsITextToSubURI,
http://lxr.mozilla.org/seamonkey/source/intl/uconv/idl/nsITextToSubURI.idl

Comment 12

[Roy Yokoyama]

Updating the target milestone.

Comment 13

[Roy Yokoyama]

changing milestone to 0.9.3

Comment 14

[Roy Yokoyama]

Attachment: Use nsITextToSubURI in nsWebShell::OnOverLink to convert the escaped text to document charset

Comment 15

[Roy Yokoyama]

nhotta: can you review? thanks

Comment 16

[nhottanscp]

r=nhotta
If you use NS_ConvertUCS2toUTF8 then no need to free the memory manually.
e.g.
rv =
textToSubURI->UnEscapeAndConvert(NS_ConvertUCS2toUTF8(charset.GetUnicode()).get(),
                                NS_ConvertUCS2toUTF8(aURLSpec).get(), &uStr);

Comment 17

[Frank Tang]

It looks like this will not only impact mailto: url but all other url. Is this
the right thing to do ?
add [e-mail] and [e-mail] to the cc list.

Comment 18

[Frank Tang]

origional I think this is a nsbranch low risk bug. But after look at the patch
and bug report. I am not that sure now. seems higher risk then I thought. 

Comment 19

[Roy Yokoyama]

Attachment: updating the patch as per nhotta's suggestion

Comment 20

[nhottanscp]

I didn't realized that this bug is orignally for mailto URI.
I will change mailto URI to use UTF-8 for bug 87202, so this patch will not work
for mailto URI.
There is a plan to make internal URI to be UTF-8.
news://news.mozilla.org/3AFAD8BC.5020805%40netscape.com
I think we want to change this part after that happens then we would only need
UCS2 to UTF-8 conversion. Sorry, I did not find it earlier.

Comment 21

[Roy Yokoyama]

Making 87202 as a depend of this bug.  Will check this bug once
we check-in the patch for 87202. 

Comment 22

[Roy Yokoyama]

Attachment: if mailtourl then UnEscape from utf-8. if not,then UnEscape from doc charset

Comment 23

[Roy Yokoyama]

nhotta: can you review?

Comment 24

[nhottanscp]

Please move nsCOMPtr<nsITextToSubURI> textToSubURI out of the if block, or not
use  nsITextToSubURI for mailto (use nsUnescape and NS_ConvertUTF8toUCS2 instead).

Comment 25

[Roy Yokoyama]

Attachment: As per hotta's suggestion: move textToSubURI out of the if block

Comment 26

[nhottanscp]

r=nhotta

Comment 27

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 28

[Roy Yokoyama]

checked-in

Comment 29

[Teruko Kobayashi]

Verified as fixed in 8-28 trunk build.