87202 - mailtourl does not support non-ASCII/non-MIME encoded header or body

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Katsuhiko Momoi]

** Observed with 6/21/2001 Win 32 build **
** This bug was split from Bug 12851. **

The above page, Netscape's Technology Evangelism Home
Page originally contained Japanese feedback pre-filled
subject line for mailtourl. I had to put in a Latin
transliteration because Mozilla does not support
non-ASCII string for header or body text for mailtourl.

In Comm 4.x, it was supported. I think we should at 
least get back to parity with 4.x.
In addition, MIME-encoded header & body should
be supported according to RFC 2368. But that is covered 
in another Bug 12851.

Comment 1

[nhottanscp]

Attachment: Patch, in nsHTMLUtils.cpp changed to create UTF-8 URI instead of a document charset, in mailnews changed ASCII conversion to UTF-8.

Comment 2

[nhottanscp]

I used diff -uw for the patch.

Comment 3

[Scott MacGregor]

Naoki, what's the risk to breaking existing ascii mailto urls that run through
that piece of compose code that you modified to change from
NS_ConvertASCIIToUCS2 to NS_ConvertUTF8ToUCS2? i.e. is that change opening us to
breaking something else?

If the answer is no then sr=mscott. Please get a reviewer from the layout group
to ok the nsHTMLUtils.cpp change.

Comment 4

[nhottanscp]

ASCII URIs are not affected by the change.
I will ask jst to also review.

Comment 5

[Johnny Stenback (:jst)]

Looks good to me r=jst

(I'd complain about the odd indentation in the mailnews file, but since that
file is an indentation nightmare (it has tabs all over, n' so on) I won't bother :-)

Comment 6

[Frank Tang]

r=ftang
check it in.

Comment 7

[Frank Tang]

land to trunk first and keep this bug open for moz0.9.2 landing.

Comment 8

[nhottanscp]

checked in to the trunk

Comment 9

[lchiang]

adding vtrunk keyword to indicate the bug has been fixed on the trunk.  Bug left
open for tracking checkin to branch (nsbranch) when appropriate.

Once bug has been fixed on the branch also, pls remove vtrunk keyword.

Comment 10

[marina]

tested in mtrunk 07-03-04 build, it is fixed

Comment 11

[Frank Tang]

mark it as vtrunk+ in staus 

Comment 12

[Frank Tang]

pdt+ per pdt meting. Land it today

Comment 13

[Frank Tang]

land into m92 branch.

Comment 14

[ji]

Verified with 07/06 windows, mac and linux branch builds. It's working for both 
subject and mail body in latin-1 or Japanese.