Port hg:ee594fb0fa3e to comm-central (Clean up configure.in a bit)

RESOLVED FIXED in Thunderbird 3.3a1

Status

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: t.matsuu, Assigned: t.matsuu)

Tracking

Trunk
Thunderbird 3.3a1
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Fit configure.in
* merge hg:ee594fb0fa3e (no bug filed)
* blanks including bug 569261
* comments
* fix partially mis-merged bug 469654
Blocks: C192ConfSync
Attachment #480888 - Attachment is patch: true
Attachment #480888 - Attachment mime type: application/octet-stream → text/plain
Attachment #480888 - Flags: review?(bugspam.Callek)
Assignee: nobody → t.matsuu
Status: NEW → ASSIGNED
Do we have to fix parenthesis issue regarding Bug 542187 comment #16 too?
Comment on attachment 480888 [details] [diff] [review]
Fit configure.in to mozilla central

>-        dnl Ensure to use an absolute path.

>     make OGLES_SDK_DIR="$OGLES_SDK_DIR" WINCE_SDK_DIR="$WINCE_SDK_DIR" \
>-         TOPSRCDIR="$_topsrcdirwin" OBJDIR="$_pwd" target="$target" \
>-         -C $srcdir/mozilla/build/wince/tools
>+    TOPSRCDIR="$_topsrcdirwin" OBJDIR="$_pwd" target="$target" \
>+    -C $srcdir/mozilla/build/wince/tools

At least these two were intentional differences.
I support fixing whitespace nits, but not making changes like these.
Attachment #480888 - Flags: feedback-
(In reply to comment #2)
> At least these two were intentional differences.

In other words, you may (try to) fix these in m-c rather.
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
Attachment #480888 - Flags: review?(bugspam.Callek)
(In reply to comment #2)
> At least these two were intentional differences.
> I support fixing whitespace nits, but not making changes like these.

Thank you for your comment.

Can I find coding guideline for scripts?
I found
https://developer.mozilla.org/En/Developer_Guide/Coding_Style
However I suppose this is for C++.
In the configure.in:
1) align by value
if test "$FOO" -o \
        "$BAR" -o \

2) 4 white spaces (sometimes 2 to 5)
if test "$FOO" = "xxx" \
    -o "$BAR" = "yyy" \

3) tabs
(In reply to comment #4)
> Can I find coding guideline for scripts?

I'm not aware of such a guideline.
(And you may not like answers in this area: I went this kind of road before, multiple times.)

My advice would be to R.Invalid this bug,
then work as in bug 506493 blocking bugs from the list at
http://dev.seamonkey.at/?d=x&i=mozilla&m=c
Status: ASSIGNED → NEW
Hmm.
So I'd like to focus on the following two issues in this bug.
* merge hg:ee594fb0fa3e (no bug filed)
* fix partially mis-merged bug 469654

And I'll pending the issues below:
* blanks including bug 569261
* comments
What do you think?
Addressed comment #6.
Attachment #480888 - Attachment is obsolete: true
Attachment #481481 - Flags: review?(bugspam.Callek)
Comment on attachment 481481 [details] [diff] [review]
Focused part of "fit configure.in to mozilla central"

disclosure, I didn't compare against m-c configure for this too much. but the changes themselves look fine, I hope to "try" and do a full-fledged merge similar to my rules.mk change I did recently, to get us up to date again.
Attachment #481481 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
Summary: More fit to mozilla-central configure.in → Port hg:ee594fb0fa3e to comm-central
Attachment #481481 - Flags: approval2.0?
Attachment #481481 - Flags: approval2.0?
Summary: Port hg:ee594fb0fa3e to comm-central → Port hg:ee594fb0fa3e to comm-central (Clean up configure.in a bit)
Checked in: http://hg.mozilla.org/comm-central/rev/16853b562855
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
Depends on: 591152
You need to log in before you can comment on or make changes to this bug.