542187 - Failed to build Firefox trunk code on OpenSolaris

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boying Lu]

When I built Firefox trunk code, I got following error:
ar -o libhostmar.a host_mar_create.o host_mar_extract.o host_mar_read.o
ar: bad option `o'
usage: ar -d[-vV] archive file ...
       ar -m[-abivV] [posname] archive file ...
       ar -p[-vV][-s] archive [file ...] 
       ar -q[-cuvV] [-abi] [posname] [file ...] 
       ar -r[-cuvV] [-abi] [posname] [file ...] 
       ar -t[-vV][-s] archive [file ...] 
       ar -x[-vV][-sCT] archive [file ...] 
gmake[5]: *** [libhostmar.a] Error 1

Comment 1

[Boying Lu]

Attachment: patch

Comment 2

[(not currently active) Ted Mielczarek]

Possible regression from bug 536440?

Comment 3

[Wan-Teh Chang]

Comment on attachment 423498 [details] [diff] [review]
patch

Brian,

Your patch doesn't seem to be the right fix because it
isn't fixing the root cause.  Please work with mwu and
Ted on the right fix.  Thanks.

Comment 4

[Wan-Teh Chang]

Ted, this seems like a double quote vs. single quote issue.
It seems that the default value for HOST_AR for the non-cross-compile
case should use single quotes instead:

417     if test -z "$HOST_AR"; then
418        HOST_AR='$AR'
419     fi

This allows a platform to override just AR later in configure.in.

Alternatively, do you think each platform that overrides
AR should also be responsible for overriding HOST_AR,
as Brian Lu's patch (attachment 423498 [details] [diff] [review]) does?

Comment 5

[Michael Wu [:mwu]]

(In reply to comment #4)
> Ted, this seems like a double quote vs. single quote issue.
> It seems that the default value for HOST_AR for the non-cross-compile
> case should use single quotes instead:
> 
That seems fairly reasonable to me, though I would want to convert all of the HOST_* defaults in the non-cross compile case to single quotes for consistency. Overriding HOST_* variables in this part of configure seems wrong to me since it should be configuring the target build settings, not the host. (but wince/winmo/windows does it anyway..)

Comment 6

[Boying Lu]

Attachment: new patch replace double quote with single quote

Comment 7

[Ginn Chen]

The patch works for me, please also apply the patch to js/src/configure.in

Comment 8

[Boying Lu]

Attachment: new patch contains js/src/configure.in

Comment 10

[Michael Wu [:mwu]]

Just a heads up - the patch for bug 538269 has just been committed, bitrotting this patch.

Comment 11

[(not currently active) Ted Mielczarek]

Comment on attachment 423969 [details] [diff] [review]
new patch contains js/src/configure.in

This looks fine.

Comment 12

[Michael Wu [:mwu]]

Attachment: As committed

http://hg.mozilla.org/mozilla-central/rev/dd503b7576cd

Comment 13

[Justin Wood (:Callek)]

Attachment: comm-central part

Comment 14

[Robert Kaiser]

Comment on attachment 427277 [details] [diff] [review]
comm-central part

I usually like it better if we do our own bugs for ports of buildsystrem stuff. creating bugs is cheap.

Comment 15

[Justin Wood (:Callek)]

Comment on attachment 427277 [details] [diff] [review]
comm-central part

Pushed as: http://hg.mozilla.org/comm-central/rev/a32f7e8e995d

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 427277 [details] [diff] [review]
comm-central part

>     if test -z "$HOST_AR"; then
>-       HOST_AR="$AR"
>+       HOST_AR='$AR'

Not your fault, but while there, could you add the missing 4th space indentation?

Also, could m-c and c-c be (kept) synchronized with/without '()'?
(I have no idea which one is the better.)

Comment 17

[Serge Gautherie (:sgautherie)]

(In reply to comment #16)
> Not your fault, but while there, could you add the missing 4th space
> indentation?

Bug 544172 will do that and port the missing HOST_AR_FLAGS too...