Closed Bug 601926 Opened 10 years ago Closed 9 years ago

Make the timeline of faceted search RTL friendly

Categories

(Thunderbird :: Search, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: Usul, Assigned: mconley)

Details

(Keywords: rtl, Whiteboard: [UXprio])

Attachments

(4 files)

With the new RTL faceted search, the timeline is still not RTL, it felt weird, but I'm not a RTL heavy user so I don't know what the best practice is.
Blake, feel free to remind me sometime at the office to look at this so that I can provide feedback on what needs to happen.
I took a look at this with Blake, and the chart needs to be flipped horizontally.  Everything else seems to be good RTL-wise.
Summary: Investigate making the timeline of faceted search RTL friendly → Make the timeline of faceted search RTL friendly
Whiteboard: [UXprio]
Blake any chances to look at this code wise ?
Yeah, I thought I'ld already done this, but I guess we just talked about it.
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Blake : ping :D
Let me try.  Blake: ping :D
Right, so I tracked this down to some SVG getting generated by the protovis library in http://mxr.mozilla.org/comm-central/source/mail/base/content/glodaFacetVis.js#199 but that's way too crazy for me, so I'mma assign it to Mike.
Assignee: bwinton → mconley
Attached patch Patch v1Splinter Review
Here's my first run at a fix.  I'll attach some screenshots next.

Try builds are coming in here:  build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=543bf87bc227
Attachment #561528 - Flags: ui-review?(bwinton)
Attachment #561528 - Flags: review?(dbienvenu)
The screenshots look great to me!
Comment on attachment 561528 [details] [diff] [review]
Patch v1

Based on the screenshots, and Ehsan's approval, I'm going to say ui-r=me!

Thanks,
Blake.
Attachment #561528 - Flags: ui-review?(bwinton) → ui-review+
Attachment #561528 - Flags: review?(dbienvenu) → review?(bugmail)
Attachment #561528 - Flags: review?(bugmail) → review+
I ran with this - it made my head hurt, but it seems to work fine.
http://hg.mozilla.org/comm-central/rev/a4a4e6f7f783
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in before you can comment on or make changes to this bug.