601926 - Make the timeline of faceted search RTL friendly

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ludovic Hirlimann [:Usul]]

With the new RTL faceted search, the timeline is still not RTL, it felt weird, but I'm not a RTL heavy user so I don't know what the best practice is.

Comment 1

[(no longer active)]

Blake, feel free to remind me sometime at the office to look at this so that I can provide feedback on what needs to happen.

Comment 2

[(no longer active)]

I took a look at this with Blake, and the chart needs to be flipped horizontally.  Everything else seems to be good RTL-wise.

Comment 3

[Ludovic Hirlimann [:Usul]]

Blake any chances to look at this code wise ?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Yeah, I thought I'ld already done this, but I guess we just talked about it.

Comment 5

[Ludovic Hirlimann [:Usul]]

Blake : ping :D

Comment 6

[(no longer active)]

Let me try.  Blake: ping :D

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Right, so I tracked this down to some SVG getting generated by the protovis library in http://mxr.mozilla.org/comm-central/source/mail/base/content/glodaFacetVis.js#199 but that's way too crazy for me, so I'mma assign it to Mike.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Here's my first run at a fix.  I'll attach some screenshots next.

Try builds are coming in here:  build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=543bf87bc227

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: LTR search for "Conley" in my inbox

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: RTL search for "Conley" in my inbox

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: RTL day of the week view.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

And here's a clickable link to the try build notifications:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=543bf87bc227

Comment 13

[(no longer active)]

The screenshots look great to me!

Comment 14

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 561528 [details] [diff] [review]
Patch v1

Based on the screenshots, and Ehsan's approval, I'm going to say ui-r=me!

Thanks,
Blake.

Comment 15

[David :Bienvenu]

I ran with this - it made my head hurt, but it seems to work fine.

Comment 16

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/a4a4e6f7f783