Closed Bug 601958 Opened 9 years ago Closed 9 years ago

TabView should directly call show and hide routines in the frame

Categories

(Firefox Graveyard :: Panorama, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 6

People

(Reporter: iangilman, Assigned: raymondlee)

Details

(Whiteboard: [API][cleanup])

Attachments

(1 file, 1 obsolete file)

Right now TabView fires "tabviewshow" and "tabviewhide" events to tell the Panorama UI frame to show/hide itself. It should just call into the frame directly, as these events confuse people looking at our API (who really want "tabviewshown" and "tabviewhidden").
Seems like something we should fix before extension authors dig in.
Blocks: 585689
Target Milestone: --- → Firefox 4.0
Unfortunately, we should punt on this.
No longer blocks: 585689
Whiteboard: [API][cleanup]
Target Milestone: Firefox 4.0 → Future
Attached patch v1 (obsolete) — Splinter Review
Trivial patch.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #519352 - Flags: review?(ian)
Comment on attachment 519352 [details] [diff] [review]
v1

Thank you for taking care of this!
Attachment #519352 - Flags: review?(ian) → review+
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/a5fce49c7f36
Keywords: checkin-needed
Whiteboard: [API][cleanup] → [API][cleanup][fixed-in-cedar]
Target Milestone: Future → Firefox 6
http://hg.mozilla.org/mozilla-central/rev/a5fce49c7f36
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [API][cleanup][fixed-in-cedar] → [API][cleanup]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.