Last Comment Bug 601958 - TabView should directly call show and hide routines in the frame
: TabView should directly call show and hide routines in the frame
Status: RESOLVED FIXED
[API][cleanup]
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: unspecified
: All All
: P3 normal
: Firefox 6
Assigned To: Raymond Lee [:raymondlee]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-05 09:42 PDT by Ian Gilman [:iangilman]
Modified: 2016-04-12 14:00 PDT (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (2.49 KB, patch)
2011-03-15 00:29 PDT, Raymond Lee [:raymondlee]
ian: review+
Details | Diff | Splinter Review
Patch for checkin (2.46 KB, patch)
2011-04-11 17:26 PDT, Raymond Lee [:raymondlee]
no flags Details | Diff | Splinter Review

Description Ian Gilman [:iangilman] 2010-10-05 09:42:00 PDT
Right now TabView fires "tabviewshow" and "tabviewhide" events to tell the Panorama UI frame to show/hide itself. It should just call into the frame directly, as these events confuse people looking at our API (who really want "tabviewshown" and "tabviewhidden").
Comment 1 Aza Raskin [:aza] 2010-10-12 01:14:37 PDT
Seems like something we should fix before extension authors dig in.
Comment 2 Michael Yoshitaka Erlewine [:mitcho] 2011-01-20 15:17:45 PST
Unfortunately, we should punt on this.
Comment 3 Raymond Lee [:raymondlee] 2011-03-15 00:29:53 PDT
Created attachment 519352 [details] [diff] [review]
v1

Trivial patch.
Comment 4 Ian Gilman [:iangilman] 2011-03-15 09:55:25 PDT
Comment on attachment 519352 [details] [diff] [review]
v1

Thank you for taking care of this!
Comment 5 Raymond Lee [:raymondlee] 2011-04-11 17:26:20 PDT
Created attachment 525231 [details] [diff] [review]
Patch for checkin

Passed Try
http://tbpl.mozilla.org/?tree=MozillaTry&rev=090f0ac0a3b1

Note You need to log in before you can comment on or make changes to this bug.