TabView should directly call show and hide routines in the frame

RESOLVED FIXED in Firefox 6

Status

Firefox Graveyard
Panorama
P3
normal
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: iangilman, Assigned: raymondlee)

Tracking

unspecified
Firefox 6

Details

(Whiteboard: [API][cleanup])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Right now TabView fires "tabviewshow" and "tabviewhide" events to tell the Panorama UI frame to show/hide itself. It should just call into the frame directly, as these events confuse people looking at our API (who really want "tabviewshown" and "tabviewhidden").

Comment 1

7 years ago
Seems like something we should fix before extension authors dig in.
Blocks: 585689
Target Milestone: --- → Firefox 4.0
Unfortunately, we should punt on this.
No longer blocks: 585689
Whiteboard: [API][cleanup]
Target Milestone: Firefox 4.0 → Future
(Assignee)

Comment 3

6 years ago
Created attachment 519352 [details] [diff] [review]
v1

Trivial patch.
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attachment #519352 - Flags: review?(ian)
(Reporter)

Comment 4

6 years ago
Comment on attachment 519352 [details] [diff] [review]
v1

Thank you for taking care of this!
Attachment #519352 - Flags: review?(ian) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 525231 [details] [diff] [review]
Patch for checkin

Passed Try
http://tbpl.mozilla.org/?tree=MozillaTry&rev=090f0ac0a3b1
Attachment #519352 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/projects/cedar/rev/a5fce49c7f36
Keywords: checkin-needed
Whiteboard: [API][cleanup] → [API][cleanup][fixed-in-cedar]
Target Milestone: Future → Firefox 6
http://hg.mozilla.org/mozilla-central/rev/a5fce49c7f36
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [API][cleanup][fixed-in-cedar] → [API][cleanup]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.