Closed
Bug 602547
Opened 14 years ago
Closed 14 years ago
Fix the browser_tabview_orphaned_tabs.js test
Categories
(Firefox Graveyard :: Panorama, defect, P1)
Firefox Graveyard
Panorama
Tracking
(blocking2.0 beta7+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
(Whiteboard: [on-panorama-central][qa-])
Attachments
(1 file)
3.56 KB,
patch
|
Dolske
:
review+
iangilman
:
feedback+
|
Details | Diff | Splinter Review |
It doesn't pass try.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #0)
> It doesn't pass try.
I mean the browser_tabview_orphaned_tabs.js test didn't pass try.
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to comment #1)
> Created attachment 481530 [details] [diff] [review]
> v1
This patch for the test is sent to try and waiting for the results
Assignee | ||
Updated•14 years ago
|
Attachment #481530 -
Flags: feedback?(ian)
Comment 4•14 years ago
|
||
Comment on attachment 481530 [details] [diff] [review]
v1
Looks good.
Btw, this is a patch for the test on bug 595893.
Attachment #481530 -
Flags: review?(dolske)
Attachment #481530 -
Flags: feedback?(ian)
Attachment #481530 -
Flags: feedback+
Comment 5•14 years ago
|
||
Dolske, can you please put this at the top of your Panorama review queue? We need it in order to merge panorama-central back to mozilla-central.
Priority: -- → P1
Comment 6•14 years ago
|
||
(In reply to comment #5)
> Dolske, can you please put this at the top of your Panorama review queue? We
> need it in order to merge panorama-central back to mozilla-central.
Forgot to cc dolske...
Comment 7•14 years ago
|
||
Try build looks clean.
Updated•14 years ago
|
Attachment #481530 -
Flags: review?(dolske) → review+
Comment 8•14 years ago
|
||
Landed on panorama-central:
http://hg.mozilla.org/users/ian_iangilman.com/panorama-central/rev/33cb1f6a7633
Whiteboard: [on-panorama-central]
Comment 9•14 years ago
|
||
Landed on mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/33cb1f6a7633
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 10•14 years ago
|
||
Can this also be landed on GECKO20b7pre_20101006_RELBRANCH?
blocking2.0: --- → beta7+
Comment 11•14 years ago
|
||
Landed for b7
Updated•14 years ago
|
Whiteboard: [on-panorama-central] → [on-panorama-central][qa-]
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•