Closed Bug 602558 Opened 15 years ago Closed 14 years ago

MSVC10 fails to compile with Google OTS source

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: By-Tor, Assigned: cjones)

References

Details

Attachments

(1 file)

Band-aid for bug 602558: Avoid the VS10 STL wrappers getting tangled up in <utility>
2.52 KB, patch
vlad
: review+
vlad
: approval2.0+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre make[5]: Entering directory `/d/build/mozilla-central/objdir-ff-release/gfx/ots/src' gasp.cc c:/mozilla-build/python/python2.6.exe -O d:/build/mozilla-central/build/cl.py cl -Fogasp.obj -c -D_HAS_EXCEPTIONS=0 -I../../../dist/stl_wrappers -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES -DOSTYPE=\"WINNT6.1\" -DOSARCH=WINNT -DPACKAGE_VERSION="\"moz\"" -DPACKAGE_BUGREPORT="\"http://bugzilla.mozilla.org/\"" -I/d/build/mozilla-central/gfx/ots/src -I/d/build/mozilla-central/gfx/ots/src -I. -I../../../dist/include -I../../../dist/include/nsprpub -Id:/build/mozilla-central/objdir-ff-release/dist/include/nspr -Id:/build/mozilla-central/objdir-ff-release/dist/include/nss -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800 -DNDEBUG -DTRIMMED -O1 -MD -FI ../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /d/build/mozilla-central/gfx/ots/src/gasp.cc gasp.cc C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(282) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(284) : see reference to class template instantiation 'std::_Is_checked_helper<_Iter>' being compiled C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(500) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(504) : see reference to class template instantiation 'std::_Ptr_cat_helper<_Elem,_Elem>' being compiled C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(500) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(503) : error C2238: unexpected token(s) preceding ';' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : error C2433: 'pair' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : error C2059: syntax error : '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2123) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2123) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C2433: 'pair' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C2086: 'int std::pair' : redefinition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : see declaration of 'std::pair' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2817) : error C2059: syntax error : '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2832) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2832) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C2433: 'pair' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C2086: 'int std::pair' : redefinition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : see declaration of 'std::pair' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2900) : error C2059: syntax error : '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2916) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2916) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(279) : error C2065: '_Left' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(279) : error C2065: '_Right' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(282) : error C2182: 'swap' : illegal use of type 'void' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(282) : error C2433: 'swap' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(282) : error C2365: 'std::swap' : redefinition; previous definition was 'function' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(100) : see declaration of 'std::swap' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(282) : error C2998: 'int std::swap' : cannot be a template definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(286) : error C2065: '_Left' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(286) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(286) : error C2059: syntax error : '&&' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(295) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(295) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(302) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(302) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(306) : error C2803: 'operator ==' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(306) : error C2805: binary 'operator ==' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(310) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(310) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(314) : error C2803: 'operator !=' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(314) : error C2805: binary 'operator !=' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(318) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(318) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(323) : error C2803: 'operator <' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(323) : error C2805: binary 'operator <' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(327) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(327) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(331) : error C2803: 'operator >' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(331) : error C2805: binary 'operator >' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(335) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(335) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(339) : error C2803: 'operator <=' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(339) : error C2805: binary 'operator <=' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(343) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(343) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(347) : error C2803: 'operator >=' must have at least one formal parameter of class type C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(347) : error C2805: binary 'operator >=' has too few parameters C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2433: 'pair' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2086: 'int std::pair' : redefinition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : see declaration of 'std::pair' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2059: syntax error : '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(353) : error C2065: '_Ty1' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(354) : error C2065: '_Ty2' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(365) : error C2065: '_Ty1' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(366) : error C2065: '_Ty2' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(368) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(368) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2143: syntax error : missing ';' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2433: 'pair' : 'inline' not permitted on data declarations C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2086: 'int std::pair' : redefinition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\xutility(2110) : see declaration of 'std::pair' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2988: unrecognizable template declaration/definition C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2059: syntax error : '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(377) : error C2065: '_Ty1' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(378) : error C2065: '_Ty2' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(389) : error C2065: '_Ty1' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(390) : error C2065: '_Ty2' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(392) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(392) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(401) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(401) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(407) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(407) : error C2143: syntax error : missing ',' before '<' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(453) : error C2977: 'std::tr1::tuple_size' : too many template arguments C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(447) : see declaration of 'std::tr1::tuple_size' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(453) : error C2143: syntax error : missing ';' before '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(453) : error C2977: 'std::tr1::tuple_size' : too many template arguments C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(447) : see declaration of 'std::tr1::tuple_size' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(453) : error C2059: syntax error : '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(454) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(454) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(463) : error C2977: 'std::tr1::_Pair_data' : too many template arguments C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(460) : see declaration of 'std::tr1::_Pair_data' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(463) : error C2143: syntax error : missing ';' before '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(463) : error C3855: 'std::tr1::_Pair_data': template parameter '_Idx' is incompatible with the declaration C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(463) : error C2059: syntax error : '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(464) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(464) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(495) : error C3855: 'std::tr1::_Pair_data': template parameter '_Idx' is incompatible with the declaration C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(499) : error C2977: 'std::tr1::tuple_element' : too many template arguments C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(450) : see declaration of 'std::tr1::tuple_element' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(499) : error C2143: syntax error : missing ';' before '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(499) : error C3855: 'std::tr1::tuple_element': template parameter '_Idx' is incompatible with the declaration C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(499) : error C2059: syntax error : '>' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(500) : error C2143: syntax error : missing ';' before '{' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(500) : error C2447: '{' : missing function header (old-style formal list?) C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(509) : error C3855: 'std::tr1::tuple_element': template parameter '_Idx' is incompatible with the declaration C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(514) : error C2039: '_Type' : is not a member of 'std::tr1::_Pair_data' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(482) : see declaration of 'std::tr1::_Pair_data' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : error C2146: syntax error : missing ';' before identifier 'get' C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : error C2065: '_Ty1' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : error C2065: '_Ty2' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : error C2065: '_Pr' : undeclared identifier C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(515) : fatal error C1003: error count exceeds 100; stopping compilation make[5]: Leaving directory `/d/build/mozilla-central/objdir-ff-release/gfx/ots/src' make[4]: Leaving directory `/d/build/mozilla-central/objdir-ff-release/gfx' make[3]: Leaving directory `/d/build/mozilla-central/objdir-ff-release' make[2]: Leaving directory `/d/build/mozilla-central/objdir-ff-release' make[1]: Leaving directory `/d/build/mozilla-central/objdir-ff-release' Reproducible: Always Fallout from bug 527276
Severity: normal → major
Depends on: CVE-2010-3768
Version: unspecified → Trunk
Component: Build Config → Layout: Text
Product: Firefox → Core
QA Contact: build.config → layout.fonts-and-text
This will be backed out when a real fix is available. I won't be able to get to that until next week.
Attachment #481692 - Flags: review?(vladimir)
Attachment #481692 - Flags: review?(vladimir)
Attachment #481692 - Flags: review+
Attachment #481692 - Flags: approval2.0+
Status: UNCONFIRMED → NEW
Ever confirmed: true
This is just a band-aid, bug is still at large.
Let's call this fixed anyways. Open new bugs for other issues.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 643460
Assignee: nobody → jones.chris.g
I've created a new bug for this problem: bug 981264.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: