602754 - Fix "a the" in comments (for NSS code)

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Edmund Wong (:ewong)]

security/nss/cmd/symkeyutil/symkey.man (View Hg log or Hg annotations)
    * line 30 -- -L takes the standard set of options. It lists all the keys in a the

security/nss/lib/softoken/legacydb/lowkeyi.h (View Hg log or Hg annotations)
    * line 99 -- ** "f" is a the callback function for getting the password

security/nss/lib/smime/smime.h (View Hg log or Hg annotations)
    * line 86 -- * XXX This is for a the current module, I think, so local, static storage

security/nss/lib/pk11wrap/pk11akey.c (View Hg log or Hg annotations)
    * line 275 -- * We need this so we can reliably determine if a the ecPoint passed to us

security/nss/lib/pk11wrap/pk11pbe.c (View Hg log or Hg annotations)
    * line 1447 -- * get a the crypto mechanism directly from the pbe algorithmid.

security/nss/lib/pkcs7/secmime.h (View Hg log or Hg annotations)
    * line 92 -- * XXX This is for a the current module, I think, so local, static storage

security/nss/lib/sqlite/sqlite3.c (View Hg log or Hg annotations)
    * line 80795 -- ** If regPrev>0 then it is a the first register in a vector that
    * line 100815 -- ** to by the argument to point a the "simple" tokenizer implementation.

security/nss/lib/jar/jarver.c (View Hg log or Hg annotations)
    * line 127 -- /* fill in the path, if supplied. This is a the location

Comment 1

[Edmund Wong (:ewong)]

(In reply to comment #0)

> security/nss/lib/sqlite/sqlite3.c (View Hg log or Hg annotations)
>     * line 80795 -- ** If regPrev>0 then it is a the first register in a vector

Not part of the bug.  Was included by mistake.  This should be for bug #602770.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Fix ' a the ' in NSS code.

Comment 3

[Edmund Wong (:ewong)]

Attachment: Fix ' a the ' in NSS code.

Added the bug # to the comment.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 482004 [details] [diff] [review]
Fix ' a the ' in NSS code.

Edmond, this patch needs to be reviewed and approved by an NSS team member.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Further, this contains a change to code inside the FIPS boundary.

Comment 6

[Edmund Wong (:ewong)]

(In reply to comment #4)
> Comment on attachment 482004 [details] [diff] [review]
> Fix ' a the ' in NSS code.
> 
> Edmond, this patch needs to be reviewed and approved by an NSS team member.

Sorry.  I made a mistake in setting up the checkin-needed and review+.  This
was supposed to be for a different bug.

Comment 7

[Edmund Wong (:ewong)]

(In reply to comment #5)
> Further, this contains a change to code inside the FIPS boundary.


My first patch was reviewed by wtc.  My second patch is a change in the bug header.

Comment 8

[Wan-Teh Chang]

Edmund: thank you for the patch.  In the future, please do not create patches that do nothing but fix spelling errors or typos, unless the spelling errors or typos cause confusion.  I stated the rationale in bug 577267 comment 1, reproduced here for your convenience:

  Correcting misspellings that that most people have no trouble
  understanding (such as receive vs. recieve and existence vs.
  existance) adds noise to source code diffs, which can hurt
  a programmer's ability to spot the important changes.

  This is why I marked this bug WONTFIX.  However, it is fine
  to correct misspellings when you fix a bug or if the
  misspellings may cause misunderstanding.

I made an exception this time because you've written
the patch before being told about this.

Patch checked in on the NSS trunk (NSS 3.13).

Checking in cmd/symkeyutil/symkey.man;
/cvsroot/mozilla/security/nss/cmd/symkeyutil/symkey.man,v  <--  symkey.man
new revision: 1.3; previous revision: 1.2
done
Checking in lib/jar/jarver.c;
/cvsroot/mozilla/security/nss/lib/jar/jarver.c,v  <--  jarver.c
new revision: 1.20; previous revision: 1.19
done
Checking in lib/pk11wrap/pk11akey.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11akey.c,v  <--  pk11akey.c
new revision: 1.32; previous revision: 1.31
done
Checking in lib/pk11wrap/pk11pbe.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pbe.c,v  <--  pk11pbe.c
new revision: 1.24; previous revision: 1.23
done
Checking in lib/smime/smime.h;
/cvsroot/mozilla/security/nss/lib/smime/smime.h,v  <--  smime.h
new revision: 1.9; previous revision: 1.8
done
Checking in lib/softoken/legacydb/lowkeyi.h;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/lowkeyi.h,v  <--  lowkeyi.h
new revision: 1.4; previous revision: 1.3
done

Comment 9

[Edmund Wong (:ewong)]

(In reply to comment #8)
> Edmund: thank you for the patch.  In the future, please do not create patches
> that do nothing but fix spelling errors or typos, unless the spelling errors or
> typos cause confusion.  I stated the rationale in bug 577267 comment 1,
> reproduced here for your convenience:

Thanks, I will definitely keep this in mind.