602971 - Changing toolbarbutton type causes item to be repositioned, when preceded by an item of higher ordinal

Status: NEW

(Core :: XUL, defect)

Description

[Matthew Turnbull [Bluefang]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre

I discovered this while working on my Status-4-Evar extension.

I was moving the statusbar element to the right end of the toolbar by setting its ordinal very high.

Users were reporting that when the AdBlock Plus toolbarbutton was on the addon-bar, it would keep moving over to the right with the statusbar. However, just opening the customization dialog would move it back to the proper location.

I discovered that ABP was programmaticly toggling the toolbarbutton's type between "menu" and "menu-button"

I've reduced this down to a fairly minimal testcase extension

Reproducible: Always

Steps to Reproduce:
1. Install Ordinal Bug extension
2. If the "Ordinal Bug" toolbar is not visible, make it visible
3. Click on the green button on the left
Actual Results:  
The green button becomes a "menu-button" and move to the right side of the toolbar

Expected Results:  
The green button should become a "menu-button" and not move

Comment 1

[Matthew Turnbull [Bluefang]]

Attachment: Ordinal Bug extension

Comment 2

[WildcatRay]

I suspect because of this issue, in the add-on/status bar I can no longer position a button to the right of any icons added by extensions/add-ons.

Comment 3

[WildcatRay]

Changed to "All" OS's as I am on Win7 64-bit. If this is incorrect, please feel free to change it to whatever is appropriate.

I am leery of changing to "NEW" without others further confirmation of this issue.

Comment 4

[Dão Gottwald [:dao]]

Ray, you're in the wrong bug.

Comment 5

[WildcatRay]

Sorry. Should I undo my gaff?

Comment 6

[Dão Gottwald [:dao]]

It's fine, I reproduced the bug on Windows with the test extension.

Comment 7

[WildcatRay]

(In reply to comment #6)
> It's fine, I reproduced the bug on Windows with the test extension.

Dao,

Thanks.

Is a separate bug needed for, in the Addon Bar, not being able to position/place a button to the right of extension icons?

Comment 8

[Matthew Turnbull [Bluefang]]

That's the point of Bug 632022

Comment 9

[WildcatRay]

(In reply to comment #8)
> That's the point of Bug 632022

I see. Thanks.