603227 - [regression] urlbar does not unfloat after dismissing awesomescreen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open Fennec
2. Tap in the urlbar to focus it.
3. Press escape ("back" on Android).
4. Scroll down.

Expected results: urlbar scrolls offscreen
Actual results: urlbar remains fixed to the top of the screen as the content pans

Possibly a regression from bug 596614.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is a regression from bug 596614

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

I've updated the patch because of a side effect of setting the element to a fixed position when showing the awesome screen. It looks liked 'fixed' position has a side effect of re-creating the inner frame for the element which kill the focused editor

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 482236 [details] [diff] [review]
Patch v0.2

I don't like the setTimeout(... 100) here. I worry about 100 -> 500 on a different device.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

setTimeout(..., 0) is the only good setTimeout unless the delay is on purpose.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This will be fixed by bug 601619

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

fixed by 601619

Comment 9

[Aakash Desai [:aakashd]]

This is not a works for me bug if there is a specific bug that fixed the issue!

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101015 Namoroka/4.0b8pre Fennec/4.0b2pre